2017-11-06 03:08:58

by Du, Changbin

[permalink] [raw]
Subject: Re: [PATCH 2/4] x86, build: Add new paths for isolinux.bin and ldlinux.c32

Hi Ingo,
On Sun, Nov 05, 2017 at 10:33:53AM +0100, Ingo Molnar wrote:
>
> * [email protected] <[email protected]> wrote:
>
> > From: Changbin Du <[email protected]>
> >
> > Recently I failed to build isoimage target, because the path of isolinux.bin
> > changed to /usr/xxx/ISOLINUX/isolinux.bin, as well as ldlinux.c32 which
> > changed to /usr/xxx/syslinux/modules/bios/ldlinux.c32.
> >
> > This patch has a improvement of the file search:
> > - Show a error message instead of silent fail.
> > - Add above new paths.
>
> How about:
>
> This patch improves the file search logic:
> - Show an error message instead of failing silently
> - Add the new paths listed above.
>
>
> > + if [ $i = end -a -z "$isolinux" ] ; then
> > + echo 'Need isolinux.bin, please install syslinux/isolinux'
>
> How about:
>
> echo 'Need an isolinux.bin file, please install syslinux/isolinux'
>
The new description is much better, will update. Thanks.

> Thanks,
>
> Ingo

--
Thanks,
Changbin Du


Attachments:
(No filename) (1.04 kB)
signature.asc (484.00 B)
Download all attachments