2017-11-08 20:17:18

by Gustavo A. R. Silva

[permalink] [raw]
Subject: Re: [PATCH v2] IB/ocrdma_hw: remove unnecessary code in ocrdma_mbx_dealloc_lkey


Quoting Leon Romanovsky <[email protected]>:

> On Tue, Nov 07, 2017 at 08:56:37AM -0600, Gustavo A. R. Silva wrote:
>>
>> Quoting Leon Romanovsky <[email protected]>:
>>
>> > On Tue, Nov 07, 2017 at 08:45:17AM -0600, Gustavo A. R. Silva wrote:
>> > > Check on return value and goto label mbx_err are unnecessary.
>> > >
>> > > Addresses-Coverity-ID: 1268780
>> > > Signed-off-by: Gustavo A. R. Silva <[email protected]>
>> > > Reviewed-by: Yuval Shaia <[email protected]>
>> > > ---
>> > > Changes in v2:
>> > > Remove assignment from "int status = -ENOMEM" as suggested by Leon
>> > > Romanovsky.
>> > >
>> > > drivers/infiniband/hw/ocrdma/ocrdma_hw.c | 6 ++----
>> > > 1 file changed, 2 insertions(+), 4 deletions(-)
>> >
>> > Please use git send-email to send patches and not reply to the
>> conversation.
>> >
>>
>> I'm using mutt.
>> What would be the advantage of using git send-email in this case?
>
> New mail headers, so it won't appear as Reply-To and will be presented
> correctly in mutt's threaded mode.
>

Oh I actually did that on purpose.

So the preferred way to do this is to send the vN of the patch as a
reply to the first patch?
or as a new thread?

Thanks
--
Gustavo A. R. Silva






From 1583459684963342788@xxx Wed Nov 08 01:33:52 +0000 2017
X-GM-THRID: 1583327717666520187
X-Gmail-Labels: Inbox,Category Forums,HistoricalUnread