On Sun, Nov 12, 2017 at 02:36:16PM +0800, [email protected] wrote:
> + asm(".set noreorder\n");
> + /* input enable */
> + outl(0x00000800, (gpio_base | 0xA0));
> + /* revert the input */
> + outl(0x00000800, (gpio_base | 0xA4));
> + /* event-int enable */
> + outl(0x00000800, (gpio_base | 0xB8));
> + asm(".set reorder\n");
I forgot to comment on this .set noreorder thing. GCC expects gas to be
in reorder mode at the end of every bit of inline assembler, so above
code is at the mercy of GCC.
Not sure what the intent was here, was it to avoid GCC from reordering
the outl() calls? These are already marked volatlile and should not be
reordered by GCC. .set (no)reorder on the other hand is a directive
to GAS and GCC won't be influenced at all by it.
Cheers,
Ralf
From 1584047906521841736@xxx Tue Nov 14 13:23:24 +0000 2017
X-GM-THRID: 1583841670985932847
X-Gmail-Labels: Inbox,Category Forums,HistoricalUnread