2017-11-15 19:44:23

by Ladislav Michl

[permalink] [raw]
Subject: Re: [PATCH v3 5/5] misc serdev: w2sg0004: add debugging code and Kconfig

On Wed, Nov 15, 2017 at 05:29:25PM +0100, H. Nikolaus Schaller wrote:
> Hi Andreas,
>
> > Am 15.11.2017 um 16:53 schrieb Andreas F�rber <[email protected]>:
> >
> > Hi,
> >
> > Am 15.11.2017 um 16:19 schrieb H. Nikolaus Schaller:
> >> This allows to set CONFIG_W2SG0004_DEBUG which will
> >> make the driver report more activities and it will turn on the
> >> GPS module during boot while the driver assumes that it
> >> is off. This can be used to debug the correct functioning of
> >> the hardware. Therefore we add it as an option to the driver
> >> because we think it is of general use (and a little tricky to
> >> add by system testers).
> >>
> >> Normally it should be off.
> >> ---
> >
> > If you want to merge this, it is lacking a Sob.
>
> Whats is a "Sob" in this context (https://acronyms.thefreedictionary.com/SOB)?

https://acronyms.thefreedictionary.com/Signed-Off-By

Also please read Documentation/process/submitting-patches.rst

ladis

> BR and thanks,
> Nikolaus Schaller
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-omap" in
> the body of a message to [email protected]
> More majordomo info at http://vger.kernel.org/majordomo-info.html

From 1584162378512056927@xxx Wed Nov 15 19:42:53 +0000 2017
X-GM-THRID: 1584152532229484824
X-Gmail-Labels: Inbox,Category Forums,HistoricalUnread


2017-11-15 17:46:18

by H. Nikolaus Schaller

[permalink] [raw]
Subject: Re: [PATCH v3 5/5] misc serdev: w2sg0004: add debugging code and Kconfig

Hi Ladislav,

> Am 15.11.2017 um 17:42 schrieb Ladislav Michl <[email protected]>:
>
> On Wed, Nov 15, 2017 at 05:29:25PM +0100, H. Nikolaus Schaller wrote:
>> Hi Andreas,
>>
>>> Am 15.11.2017 um 16:53 schrieb Andreas F?rber <[email protected]>:
>>>
>>> Hi,
>>>
>>> Am 15.11.2017 um 16:19 schrieb H. Nikolaus Schaller:
>>>> This allows to set CONFIG_W2SG0004_DEBUG which will
>>>> make the driver report more activities and it will turn on the
>>>> GPS module during boot while the driver assumes that it
>>>> is off. This can be used to debug the correct functioning of
>>>> the hardware. Therefore we add it as an option to the driver
>>>> because we think it is of general use (and a little tricky to
>>>> add by system testers).
>>>>
>>>> Normally it should be off.
>>>> ---
>>>
>>> If you want to merge this, it is lacking a Sob.
>>
>> Whats is a "Sob" in this context (https://acronyms.thefreedictionary.com/SOB)?
>
> https://acronyms.thefreedictionary.com/Signed-Off-By

Ah, ok. Too obvious to associate :) Tnx.

I did never think about that this could be missing. And I don't know why :(

> Also please read Documentation/process/submitting-patches.rst

We have automated things by calling checkpatch but it somwhow failed here.

BR and thanks,
Nikolaus


From 1584153060362365990@xxx Wed Nov 15 17:14:46 +0000 2017
X-GM-THRID: 1584152532229484824
X-Gmail-Labels: Inbox,Category Forums,HistoricalUnread