2017-11-20 19:27:08

by Stephen Boyd

[permalink] [raw]
Subject: Re: [PATCH] mmc: sdhci-msm: Optionally wait for signal level changes

On 11/20, Bjorn Andersson wrote:
> Not all instances of the SDCC core supports changing signal voltage and
> as such will not generate a power interrupt when the software attempts
> to change the voltage. This results in probing the eMMC on some devices
> to take over 2 minutes.
>
> Check that the SWITCHABLE_SIGNAL_VOLTAGE bit in MCI_GENERICS is set

T in SWITCHABLE_SIGNAL_VOLTAGE here.

> before waiting for the power interrupt.
>
> Cc: Sahitya Tummala <[email protected]>
> Cc: Vijay Viswanath <[email protected]>
> Fixes: c0309b3803fe ("mmc: sdhci-msm: Add sdhci msm register write APIs which wait for pwr irq")
> Signed-off-by: Bjorn Andersson <[email protected]>
> ---
>
> The offending patch is part of your v4.15 pull request, so please pick
> this up for the -rcs.
>
> drivers/mmc/host/sdhci-msm.c | 14 ++++++++++++++
> 1 file changed, 14 insertions(+)
>
> diff --git a/drivers/mmc/host/sdhci-msm.c b/drivers/mmc/host/sdhci-msm.c
> index 3fb7d2eec93f..8f2dda73e6b4 100644
> --- a/drivers/mmc/host/sdhci-msm.c
> +++ b/drivers/mmc/host/sdhci-msm.c
> @@ -29,6 +29,9 @@
> #define CORE_VERSION_MAJOR_MASK (0xf << CORE_VERSION_MAJOR_SHIFT)
> #define CORE_VERSION_MINOR_MASK 0xff
>
> +#define CORE_MCI_GENERICS 0x70
> +#define SWICHABLE_SIGNALING_VOLTAGE BIT(29)

But then the T isn't here.

--
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
a Linux Foundation Collaborative Project

From 1584611141081416243@xxx Mon Nov 20 18:35:46 +0000 2017
X-GM-THRID: 1584611141081416243
X-Gmail-Labels: Inbox,Category Forums,HistoricalUnread