2017-11-23 15:51:15

by Alasdair G Kergon

Subject: Re: [dm-devel] [PATCH 3/4] dm: convert dm_dev_internal.count from atomic_t to refcount_t

On Fri, Oct 20, 2017 at 10:37:38AM +0300, Elena Reshetova wrote:
> } else if (dd->dm_dev->mode != (mode | dd->dm_dev->mode)) {
> r = upgrade_mode(dd, mode, t->md);
> if (r)
> return r;
> + refcount_inc(&dd->count);
> }

Missing here:

else
refcount_inc(&dd->count);

?

Alasdair


From 1581761449867113637@xxx Fri Oct 20 07:41:09 +0000 2017
X-GM-THRID: 1581761449867113637
X-Gmail-Labels: Inbox,Category Forums