2017-08-10 08:54:30

by Thomas Meyer

Subject: [PATCH] auxdisplay: img-ascii-lcd: Only build on archs that have IOMEM

This avoids the MODPOST error:
ERROR: "devm_ioremap_resource" [drivers/auxdisplay/img-ascii-lcd.ko] undefined!

Signed-off-by: Thomas Meyer <[email protected]>
---
drivers/auxdisplay/Kconfig | 1 +
1 file changed, 1 insertion(+)

diff --git a/drivers/auxdisplay/Kconfig b/drivers/auxdisplay/Kconfig
index 9ae6681c90ad..9088c66e4c08 100644
--- a/drivers/auxdisplay/Kconfig
+++ b/drivers/auxdisplay/Kconfig
@@ -135,6 +135,7 @@ config CFAG12864B_RATE

config IMG_ASCII_LCD
tristate "Imagination Technologies ASCII LCD Display"
+ depends on HAS_IOMEM
default y if MIPS_MALTA || MIPS_SEAD3
select SYSCON
help
--
2.13.3

2017-08-10 18:24:09

by Randy Dunlap

Subject: Re: [PATCH] auxdisplay: img-ascii-lcd: Only build on archs that have IOMEM

On 08/10/2017 01:53 AM, Thomas Meyer wrote:
> This avoids the MODPOST error:
> ERROR: "devm_ioremap_resource" [drivers/auxdisplay/img-ascii-lcd.ko] undefined!
>
> Signed-off-by: Thomas Meyer <[email protected]>
> ---
> drivers/auxdisplay/Kconfig | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/auxdisplay/Kconfig b/drivers/auxdisplay/Kconfig
> index 9ae6681c90ad..9088c66e4c08 100644
> --- a/drivers/auxdisplay/Kconfig
> +++ b/drivers/auxdisplay/Kconfig
> @@ -135,6 +135,7 @@ config CFAG12864B_RATE
>
> config IMG_ASCII_LCD
> tristate "Imagination Technologies ASCII LCD Display"
> + depends on HAS_IOMEM
> default y if MIPS_MALTA || MIPS_SEAD3
> select SYSCON
> help
>

I posted the same patch on 2017-JAN-01, so I agree with it.

https://lkml.org/lkml/2017/1/1/87

Acked-by: Randy Dunlap <[email protected]>

--
~Randy

2017-11-27 20:38:30

by Linus Torvalds

Subject: Re: [PATCH] auxdisplay: img-ascii-lcd: Only build on archs that have IOMEM

On Mon, Nov 27, 2017 at 12:05 PM, Thomas Meyer <[email protected]> wrote:
>
> No response from the maintainer yet. I think this driver is actually unmaintained.
> What to do now?

Applied directly.

Linus

From 1585252471482539938@xxx Mon Nov 27 20:29:27 +0000 2017
X-GM-THRID: 1575333722277882027
X-Gmail-Labels: Inbox,Category Forums,HistoricalUnread

2017-11-27 20:29:27

by Thomas Meyer

Subject: Re: [PATCH] auxdisplay: img-ascii-lcd: Only build on archs that have IOMEM

On Thu, Aug 10, 2017 at 11:24:04AM -0700, Randy Dunlap wrote:
> On 08/10/2017 01:53 AM, Thomas Meyer wrote:
> > This avoids the MODPOST error:
> > ERROR: "devm_ioremap_resource" [drivers/auxdisplay/img-ascii-lcd.ko] undefined!
> >
> > Signed-off-by: Thomas Meyer <[email protected]>
> > ---
> > drivers/auxdisplay/Kconfig | 1 +
> > 1 file changed, 1 insertion(+)
> >
> > diff --git a/drivers/auxdisplay/Kconfig b/drivers/auxdisplay/Kconfig
> > index 9ae6681c90ad..9088c66e4c08 100644
> > --- a/drivers/auxdisplay/Kconfig
> > +++ b/drivers/auxdisplay/Kconfig
> > @@ -135,6 +135,7 @@ config CFAG12864B_RATE
> >
> > config IMG_ASCII_LCD
> > tristate "Imagination Technologies ASCII LCD Display"
> > + depends on HAS_IOMEM
> > default y if MIPS_MALTA || MIPS_SEAD3
> > select SYSCON
> > help
> >
>
> I posted the same patch on 2017-JAN-01, so I agree with it.
>
> https://lkml.org/lkml/2017/1/1/87
>
> Acked-by: Randy Dunlap <[email protected]>

No response from the maintainer yet. I think this driver is actually unmaintained.
What to do now?

>
> --
> ~Randy

From 1575369548541898527@xxx Thu Aug 10 18:24:37 +0000 2017
X-GM-THRID: 1575333722277882027
X-Gmail-Labels: Inbox,Category Forums