2017-11-29 01:09:40

by Jakub Kicinski

[permalink] [raw]
Subject: Re: [PATCH 11/17] cls_bpf: Convert to use idr_alloc_u32

On Tue, 28 Nov 2017 13:33:06 -0800, Matthew Wilcox wrote:
> + ret = idr_alloc_u32(&head->handle_idr, prog, &handle,
> + INT_MAX, GFP_KERNEL);
> + } else if (!oldprog) {
> + ret = idr_alloc_u32(&head->handle_idr, prog, &handle,
> + handle, GFP_KERNEL);

nit: in many places you seem to not align the second line with opening
parenthesis. Is that intentional?

FWIW there may be a small merge conflict with net on cls_bpf in patch
5, some of the code has been removed.

From 1585347242762717100@xxx Tue Nov 28 21:35:48 +0000 2017
X-GM-THRID: 1585347242762717100
X-Gmail-Labels: Inbox,Category Forums,HistoricalUnread