Acked-by: Gabriel Somlo <[email protected]>
On Tue, Nov 28, 2017 at 10:40:27PM +0100, Vasyl Gomonovych wrote:
> Fix ptr_ret.cocci warnings:
> drivers/firmware/efi/efi.c:610:8-14: WARNING: PTR_ERR_OR_ZERO can be used
>
> Use PTR_ERR_OR_ZERO rather than if(IS_ERR(...)) + PTR_ERR
>
> Generated by: scripts/coccinelle/api/ptr_ret.cocci
>
> Signed-off-by: Vasyl Gomonovych <[email protected]>
> ---
> drivers/firmware/qemu_fw_cfg.c | 4 +---
> 1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/drivers/firmware/qemu_fw_cfg.c b/drivers/firmware/qemu_fw_cfg.c
> index 5cfe39f7a45f..18489b6a696d 100644
> --- a/drivers/firmware/qemu_fw_cfg.c
> +++ b/drivers/firmware/qemu_fw_cfg.c
> @@ -693,10 +693,8 @@ static int fw_cfg_cmdline_set(const char *arg, const struct kernel_param *kp)
> */
> fw_cfg_cmdline_dev = platform_device_register_simple("fw_cfg",
> PLATFORM_DEVID_NONE, res, processed);
> - if (IS_ERR(fw_cfg_cmdline_dev))
> - return PTR_ERR(fw_cfg_cmdline_dev);
>
> - return 0;
> + return PTR_ERR_OR_ZERO(fw_cfg_cmdline_dev);
> }
>
> static int fw_cfg_cmdline_get(char *buf, const struct kernel_param *kp)
> --
> 1.9.1
>
From 1585347660432402973@xxx Tue Nov 28 21:42:26 +0000 2017
X-GM-THRID: 1585347660432402973
X-Gmail-Labels: Inbox,Category Forums,HistoricalUnread