2017-12-13 08:21:22

by Dhaval Shah

Subject: [PATCH] platform/x86: dell-smbios: Block comments use * on subsequent lines

Resolved Block comments use * on subsequent lines checkpatch warnings.
Issue found by checkpatch.

Signed-off-by: Dhaval Shah <[email protected]>
---
drivers/platform/x86/dell-smbios.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/drivers/platform/x86/dell-smbios.c b/drivers/platform/x86/dell-smbios.c
index 6a60db515bda..25a296c90e08 100644
--- a/drivers/platform/x86/dell-smbios.c
+++ b/drivers/platform/x86/dell-smbios.c
@@ -353,7 +353,8 @@ static void __init parse_da_table(const struct dmi_header *dm)
container_of(dm, struct calling_interface_structure, header);

/* 4 bytes of table header, plus 7 bytes of Dell header, plus at least
- 6 bytes of entry */
+ * 6 bytes of entry
+ */

if (dm->length < 17)
return;
--
2.11.0

2017-12-14 17:59:11

by Andy Shevchenko

Subject: Re: [PATCH] platform/x86: dell-smbios: Block comments use * on subsequent lines

On Wed, Dec 13, 2017 at 10:21 AM, Dhaval Shah
<[email protected]> wrote:
> Resolved Block comments use * on subsequent lines checkpatch warnings.
> Issue found by checkpatch.
>

Same comments as for the other like this

> Signed-off-by: Dhaval Shah <[email protected]>
> ---
> drivers/platform/x86/dell-smbios.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/platform/x86/dell-smbios.c b/drivers/platform/x86/dell-smbios.c
> index 6a60db515bda..25a296c90e08 100644
> --- a/drivers/platform/x86/dell-smbios.c
> +++ b/drivers/platform/x86/dell-smbios.c
> @@ -353,7 +353,8 @@ static void __init parse_da_table(const struct dmi_header *dm)
> container_of(dm, struct calling_interface_structure, header);
>
> /* 4 bytes of table header, plus 7 bytes of Dell header, plus at least
> - 6 bytes of entry */
> + * 6 bytes of entry
> + */
>
> if (dm->length < 17)
> return;
> --
> 2.11.0
>



--
With Best Regards,
Andy Shevchenko

2017-12-15 05:17:54

by Dhaval Shah

Subject: Re: [PATCH] platform/x86: dell-smbios: Block comments use * on subsequent lines

Hi Andy Shevchenko,

________________________________________
> From: Andy Shevchenko <[email protected]>
> Sent: Thursday, December 14, 2017 11:29 PM
> To: Dhaval Shah
> Cc: Pali Roh?r; Mario Limonciello; [email protected]; Andy Shevchenko; Platform Driver; [email protected]
> Subject: Re: [PATCH] platform/x86: dell-smbios: Block comments use * on subsequent lines
>
> On Wed, Dec 13, 2017 at 10:21 AM, Dhaval Shah
> <[email protected]> wrote:
> > Resolved Block comments use * on subsequent lines checkpatch warnings.
> > Issue found by checkpatch.
> >
>
> Same comments as for the other like this
>

This changes will not affect the functionality but improves the code readability.

> > Signed-off-by: Dhaval Shah <[email protected]>
> > ---
> > drivers/platform/x86/dell-smbios.c | 3 ++-
> > 1 file changed, 2 insertions(+), 1 deletion(-)
> >
> > diff --git a/drivers/platform/x86/dell-smbios.c b/drivers/platform/x86/dell-smbios.c
> > index 6a60db515bda..25a296c90e08 100644
> > --- a/drivers/platform/x86/dell-smbios.c
> > +++ b/drivers/platform/x86/dell-smbios.c
> > @@ -353,7 +353,8 @@ static void __init parse_da_table(const struct dmi_header *dm)
> > container_of(dm, struct calling_interface_structure, header);
> >
> > /* 4 bytes of table header, plus 7 bytes of Dell header, plus at least
> > - 6 bytes of entry */
> > + * 6 bytes of entry
> > + */
> >
> > if (dm->length < 17)
> > return;
> > --
> > 2.11.0
> >



--
With Best Regards,
Andy Shevchenko