2017-12-13 14:43:23

by Hao Zhang

[permalink] [raw]
Subject: [PATCH v4 1/4] dt-bindings: pwm: binding allwinner sun8i R40/V40/T3.

This patch adds allwinner R40, V40, T3 pwm binding documents.

Signed-off-by: hao_zhang <[email protected]>
---
Documentation/devicetree/bindings/pwm/pwm-sun8i.txt | 18 ++++++++++++++++++
1 file changed, 18 insertions(+)
create mode 100644 Documentation/devicetree/bindings/pwm/pwm-sun8i.txt

diff --git a/Documentation/devicetree/bindings/pwm/pwm-sun8i.txt b/Documentation/devicetree/bindings/pwm/pwm-sun8i.txt
new file mode 100644
index 0000000..76750d8
--- /dev/null
+++ b/Documentation/devicetree/bindings/pwm/pwm-sun8i.txt
@@ -0,0 +1,18 @@
+Allwinner sun8i R40/V40/T3 SoC PWM controller
+
+Required properties:
+- compatible: should be one of:
+- "allwinner,sun8i-r40-pwm"
+- reg: physical base address and length of the controller's registers
+- #pwm-cells: should be 3. See pwm.txt in this directory for a description of
+the cells format.
+- clocks: From common clock binding, handle to the parent clock.
+
+Example:
+
+pwm: pwm@1c23400 {
+ compatible = "allwinner,sun8i-r40-pwm";
+ reg = <0x01c23400 0x154>;
+ clocks = <&osc24M>;
+ #pwm-cells = <3>;
+};
--
2.7.4


2017-12-13 15:50:04

by Maxime Ripard

[permalink] [raw]
Subject: Re: [PATCH v4 1/4] dt-bindings: pwm: binding allwinner sun8i R40/V40/T3.

Hi,

On Wed, Dec 13, 2017 at 10:43:09PM +0800, hao_zhang wrote:
> This patch adds allwinner R40, V40, T3 pwm binding documents.
>
> Signed-off-by: hao_zhang <[email protected]>
> ---
> Documentation/devicetree/bindings/pwm/pwm-sun8i.txt | 18 ++++++++++++++++++
> 1 file changed, 18 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/pwm/pwm-sun8i.txt
>
> diff --git a/Documentation/devicetree/bindings/pwm/pwm-sun8i.txt b/Documentation/devicetree/bindings/pwm/pwm-sun8i.txt
> new file mode 100644
> index 0000000..76750d8
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/pwm/pwm-sun8i.txt
> @@ -0,0 +1,18 @@
> +Allwinner sun8i R40/V40/T3 SoC PWM controller
> +
> +Required properties:
> +- compatible: should be one of:
> +- "allwinner,sun8i-r40-pwm"

Please indent that part.

Once fixed,
Acked-by: Maxime Ripard <[email protected]>

Thanks!
Maxime

--
Maxime Ripard, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com


Attachments:
(No filename) (999.00 B)
signature.asc (833.00 B)
Download all attachments