2017-12-20 05:40:44

by Wei Yongjun

Subject: [PATCH -next] mtd: sharpslpart: make local function sharpsl_nand_cleanup_ftl() static

Fixes the following sparse warnings:

drivers/mtd/parsers/sharpslpart.c:222:6: warning:
symbol 'sharpsl_nand_cleanup_ftl' was not declared. Should it be static?

Signed-off-by: Wei Yongjun <[email protected]>
---
drivers/mtd/parsers/sharpslpart.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/mtd/parsers/sharpslpart.c b/drivers/mtd/parsers/sharpslpart.c
index 0ddb79a..8893dc8 100644
--- a/drivers/mtd/parsers/sharpslpart.c
+++ b/drivers/mtd/parsers/sharpslpart.c
@@ -219,7 +219,7 @@ static int sharpsl_nand_init_ftl(struct mtd_info *mtd, struct sharpsl_ftl *ftl)
return ret;
}

-void sharpsl_nand_cleanup_ftl(struct sharpsl_ftl *ftl)
+static void sharpsl_nand_cleanup_ftl(struct sharpsl_ftl *ftl)
{
kfree(ftl->log2phy);
}

2017-12-22 10:09:38

by Andrea Adami

Subject: Re: [PATCH -next] mtd: sharpslpart: make local function sharpsl_nand_cleanup_ftl() static

On Wed, Dec 20, 2017 at 6:45 AM, Wei Yongjun <[email protected]> wrote:
> Fixes the following sparse warnings:
>
> drivers/mtd/parsers/sharpslpart.c:222:6: warning:
> symbol 'sharpsl_nand_cleanup_ftl' was not declared. Should it be static?
>
> Signed-off-by: Wei Yongjun <[email protected]>
> ---
> drivers/mtd/parsers/sharpslpart.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/mtd/parsers/sharpslpart.c b/drivers/mtd/parsers/sharpslpart.c
> index 0ddb79a..8893dc8 100644
> --- a/drivers/mtd/parsers/sharpslpart.c
> +++ b/drivers/mtd/parsers/sharpslpart.c
> @@ -219,7 +219,7 @@ static int sharpsl_nand_init_ftl(struct mtd_info *mtd, struct sharpsl_ftl *ftl)
> return ret;
> }
>
> -void sharpsl_nand_cleanup_ftl(struct sharpsl_ftl *ftl)
> +static void sharpsl_nand_cleanup_ftl(struct sharpsl_ftl *ftl)
> {
> kfree(ftl->log2phy);
> }
>

Thanks, this should be indeed static like the other functions.

Acked-by: Andrea Adami <[email protected]>

2018-01-06 20:44:19

by Boris Brezillon

Subject: Re: [PATCH -next] mtd: sharpslpart: make local function sharpsl_nand_cleanup_ftl() static

On Fri, 22 Dec 2017 11:09:15 +0100
Andrea Adami <[email protected]> wrote:

> On Wed, Dec 20, 2017 at 6:45 AM, Wei Yongjun <[email protected]> wrote:
> > Fixes the following sparse warnings:
> >
> > drivers/mtd/parsers/sharpslpart.c:222:6: warning:
> > symbol 'sharpsl_nand_cleanup_ftl' was not declared. Should it be static?
> >
> > Signed-off-by: Wei Yongjun <[email protected]>
> > ---
> > drivers/mtd/parsers/sharpslpart.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/mtd/parsers/sharpslpart.c b/drivers/mtd/parsers/sharpslpart.c
> > index 0ddb79a..8893dc8 100644
> > --- a/drivers/mtd/parsers/sharpslpart.c
> > +++ b/drivers/mtd/parsers/sharpslpart.c
> > @@ -219,7 +219,7 @@ static int sharpsl_nand_init_ftl(struct mtd_info *mtd, struct sharpsl_ftl *ftl)
> > return ret;
> > }
> >
> > -void sharpsl_nand_cleanup_ftl(struct sharpsl_ftl *ftl)
> > +static void sharpsl_nand_cleanup_ftl(struct sharpsl_ftl *ftl)
> > {
> > kfree(ftl->log2phy);
> > }
> >
>
> Thanks, this should be indeed static like the other functions.
>
> Acked-by: Andrea Adami <[email protected]>
>

Applied.

Thanks,

Boris

> ______________________________________________________
> Linux MTD discussion mailing list
> http://lists.infradead.org/mailman/listinfo/linux-mtd/