2018-01-16 09:06:14

by Liu, Changcheng

Subject: [PATCH] rcu: remove redundant nxttail index marco define

rcu nxttail has been optimized to be rcu_segcblist.
The index has been defined in linux/rcu_segcblist.h

Signed-off-by: Liu Changcheng <[email protected]>

diff --git a/kernel/rcu/tree.h b/kernel/rcu/tree.h
index 46a5d19..78cb5f3 100644
--- a/kernel/rcu/tree.h
+++ b/kernel/rcu/tree.h
@@ -185,13 +185,6 @@ union rcu_noqs {
u16 s; /* Set of bits, aggregate OR here. */
};

-/* Index values for nxttail array in struct rcu_data. */
-#define RCU_DONE_TAIL 0 /* Also RCU_WAIT head. */
-#define RCU_WAIT_TAIL 1 /* Also RCU_NEXT_READY head. */
-#define RCU_NEXT_READY_TAIL 2 /* Also RCU_NEXT head. */
-#define RCU_NEXT_TAIL 3
-#define RCU_NEXT_SIZE 4
-
/* Per-CPU data for read-copy update. */
struct rcu_data {
/* 1) quiescent-state and grace-period handling : */
--
2.7.4

2018-01-16 15:31:40

by Paul E. McKenney

Subject: Re: [PATCH] rcu: remove redundant nxttail index marco define

On Tue, Jan 16, 2018 at 05:05:14PM +0800, Liu, Changcheng wrote:
> rcu nxttail has been optimized to be rcu_segcblist.
> The index has been defined in linux/rcu_segcblist.h
>
> Signed-off-by: Liu Changcheng <[email protected]>

Good eyes! Applied for testing and review.

Thanx, Paul

> diff --git a/kernel/rcu/tree.h b/kernel/rcu/tree.h
> index 46a5d19..78cb5f3 100644
> --- a/kernel/rcu/tree.h
> +++ b/kernel/rcu/tree.h
> @@ -185,13 +185,6 @@ union rcu_noqs {
> u16 s; /* Set of bits, aggregate OR here. */
> };
>
> -/* Index values for nxttail array in struct rcu_data. */
> -#define RCU_DONE_TAIL 0 /* Also RCU_WAIT head. */
> -#define RCU_WAIT_TAIL 1 /* Also RCU_NEXT_READY head. */
> -#define RCU_NEXT_READY_TAIL 2 /* Also RCU_NEXT head. */
> -#define RCU_NEXT_TAIL 3
> -#define RCU_NEXT_SIZE 4
> -
> /* Per-CPU data for read-copy update. */
> struct rcu_data {
> /* 1) quiescent-state and grace-period handling : */
> --
> 2.7.4
>