2018-01-16 15:03:49

by Luis de Bethencourt

Subject: [PATCH] vxlan: Fix trailing semicolon

The trailing semicolon is an empty statement that does no operation.
It is completely stripped out by the compiler. Removing it since it doesn't do
anything.

Signed-off-by: Luis de Bethencourt <[email protected]>
---

Hi,

An other trailing semicolon to remove.

Best regards
Luis


[0] http://driverdev.linuxdriverproject.org/pipermail/driverdev-devel/2018-January/115410.html
[1] http://driverdev.linuxdriverproject.org/pipermail/driverdev-devel/2018-January/115390.html

include/net/vxlan.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/include/net/vxlan.h b/include/net/vxlan.h
index f96391e84a8a..ad73d8b3fcc2 100644
--- a/include/net/vxlan.h
+++ b/include/net/vxlan.h
@@ -301,7 +301,7 @@ static inline netdev_features_t vxlan_features_check(struct sk_buff *skb,
l4_hdr = ipv6_hdr(skb)->nexthdr;
break;
default:
- return features;;
+ return features;
}

if ((l4_hdr == IPPROTO_UDP) &&
--
2.15.1

2018-01-16 17:48:44

by Stephen Hemminger

Subject: Re: [PATCH] vxlan: Fix trailing semicolon

On Tue, 16 Jan 2018 15:03:32 +0000
Luis de Bethencourt <[email protected]> wrote:

> The trailing semicolon is an empty statement that does no operation.
> It is completely stripped out by the compiler. Removing it since it doesn't do
> anything.
>
> Signed-off-by: Luis de Bethencourt <[email protected]>
> ---
>
> Hi,
>
> An other trailing semicolon to remove.
>
> Best regards
> Luis
>
>
> [0] http://driverdev.linuxdriverproject.org/pipermail/driverdev-devel/2018-January/115410.html
> [1] http://driverdev.linuxdriverproject.org/pipermail/driverdev-devel/2018-January/115390.html
>
> include/net/vxlan.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/include/net/vxlan.h b/include/net/vxlan.h
> index f96391e84a8a..ad73d8b3fcc2 100644
> --- a/include/net/vxlan.h
> +++ b/include/net/vxlan.h
> @@ -301,7 +301,7 @@ static inline netdev_features_t vxlan_features_check(struct sk_buff *skb,
> l4_hdr = ipv6_hdr(skb)->nexthdr;
> break;
> default:
> - return features;;
> + return features;
> }
>
> if ((l4_hdr == IPPROTO_UDP) &&

Fixes: 5f35227ea34b ("net: Generalize ndo_gso_check to ndo_features_check")

Acked-by: Stephen Hemminger <[email protected]>

2018-01-17 21:08:14

by David Miller

Subject: Re: [PATCH] vxlan: Fix trailing semicolon

From: Luis de Bethencourt <[email protected]>
Date: Tue, 16 Jan 2018 15:03:32 +0000

> The trailing semicolon is an empty statement that does no operation.
> It is completely stripped out by the compiler. Removing it since it doesn't do
> anything.
>
> Signed-off-by: Luis de Bethencourt <[email protected]>

Applied to net-next, thanks.