2018-01-18 22:50:41

by Gustavo A. R. Silva

[permalink] [raw]
Subject: [PATCH] usb: gadget: compress return logic into one line

Simplify return logic and avoid unnecessary variable assignment.

Signed-off-by: Gustavo A. R. Silva <[email protected]>
---
drivers/usb/gadget/legacy/ncm.c | 6 ++----
1 file changed, 2 insertions(+), 4 deletions(-)

diff --git a/drivers/usb/gadget/legacy/ncm.c b/drivers/usb/gadget/legacy/ncm.c
index fcee1ee0..8465f08 100644
--- a/drivers/usb/gadget/legacy/ncm.c
+++ b/drivers/usb/gadget/legacy/ncm.c
@@ -102,10 +102,8 @@ static int ncm_do_config(struct usb_configuration *c)
}

f_ncm = usb_get_function(f_ncm_inst);
- if (IS_ERR(f_ncm)) {
- status = PTR_ERR(f_ncm);
- return status;
- }
+ if (IS_ERR(f_ncm))
+ return PTR_ERR(f_ncm);

status = usb_add_function(c, f_ncm);
if (status < 0) {
--
2.7.4