2018-01-25 01:25:18

by Ivan Delalande

Subject: [PATCH] lkdtm: fix handle_irq_event symbol for INT_HW_IRQ_EN

Function handle_IRQ_event was retired in v2.6.39 and replaced with
handle_irq_event but nobody changed it in lkdtm so INT_HW_IRQ_EN has
been broken for a while.

Fixes: 33b054b867b8 ("genirq: Remove handle_IRQ_event")
Signed-off-by: Travis Brown <[email protected]>
Signed-off-by: Ivan Delalande <[email protected]>
---
drivers/misc/lkdtm_core.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/misc/lkdtm_core.c b/drivers/misc/lkdtm_core.c
index ba92291508dc..4942da93d066 100644
--- a/drivers/misc/lkdtm_core.c
+++ b/drivers/misc/lkdtm_core.c
@@ -96,7 +96,7 @@ static struct crashpoint crashpoints[] = {
CRASHPOINT("DIRECT", NULL),
#ifdef CONFIG_KPROBES
CRASHPOINT("INT_HARDWARE_ENTRY", "do_IRQ"),
- CRASHPOINT("INT_HW_IRQ_EN", "handle_IRQ_event"),
+ CRASHPOINT("INT_HW_IRQ_EN", "handle_irq_event"),
CRASHPOINT("INT_TASKLET_ENTRY", "tasklet_action"),
CRASHPOINT("FS_DEVRW", "ll_rw_block"),
CRASHPOINT("MEM_SWAPOUT", "shrink_inactive_list"),
--
2.16.1

2018-01-25 02:35:48

by Kees Cook

Subject: Re: [PATCH] lkdtm: fix handle_irq_event symbol for INT_HW_IRQ_EN

On Thu, Jan 25, 2018 at 12:16 PM, Ivan Delalande <[email protected]> wrote:
> Function handle_IRQ_event was retired in v2.6.39 and replaced with
> handle_irq_event but nobody changed it in lkdtm so INT_HW_IRQ_EN has
> been broken for a while.

Excellent, thanks for the fix!

Acked-by: Kees Cook <[email protected]>

Greg, I don't have any other exclusive lkdtm updates, so please feel
free to apply this to misc-next.

Thanks!

-Kees

>
> Fixes: 33b054b867b8 ("genirq: Remove handle_IRQ_event")
> Signed-off-by: Travis Brown <[email protected]>
> Signed-off-by: Ivan Delalande <[email protected]>
> ---
> drivers/misc/lkdtm_core.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/misc/lkdtm_core.c b/drivers/misc/lkdtm_core.c
> index ba92291508dc..4942da93d066 100644
> --- a/drivers/misc/lkdtm_core.c
> +++ b/drivers/misc/lkdtm_core.c
> @@ -96,7 +96,7 @@ static struct crashpoint crashpoints[] = {
> CRASHPOINT("DIRECT", NULL),
> #ifdef CONFIG_KPROBES
> CRASHPOINT("INT_HARDWARE_ENTRY", "do_IRQ"),
> - CRASHPOINT("INT_HW_IRQ_EN", "handle_IRQ_event"),
> + CRASHPOINT("INT_HW_IRQ_EN", "handle_irq_event"),
> CRASHPOINT("INT_TASKLET_ENTRY", "tasklet_action"),
> CRASHPOINT("FS_DEVRW", "ll_rw_block"),
> CRASHPOINT("MEM_SWAPOUT", "shrink_inactive_list"),
> --
> 2.16.1



--
Kees Cook
Pixel Security