2018-02-06 14:50:55

by Colin King

Subject: [PATCH] kasan: remove redundant initialization of variable 'real_size'

From: Colin Ian King <[email protected]>

Variable real_size is initialized with a value that is never read,
it is re-assigned a new value later on, hence the initialization is
redundant and can be removed.

Cleans up clang warning:
lib/test_kasan.c:422:21: warning: Value stored to 'real_size' during
its initialization is never read

Signed-off-by: Colin Ian King <[email protected]>
---
lib/test_kasan.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/lib/test_kasan.c b/lib/test_kasan.c
index a808d81b409d..dba0ffd45fd7 100644
--- a/lib/test_kasan.c
+++ b/lib/test_kasan.c
@@ -419,7 +419,7 @@ static noinline void __init kasan_stack_oob(void)
static noinline void __init ksize_unpoisons_memory(void)
{
char *ptr;
- size_t size = 123, real_size = size;
+ size_t size = 123, real_size;

pr_info("ksize() unpoisons the whole allocated chunk\n");
ptr = kmalloc(size, GFP_KERNEL);
--
2.15.1

2018-02-06 20:11:53

by Andrey Ryabinin

Subject: Re: [PATCH] kasan: remove redundant initialization of variable 'real_size'

On 02/06/2018 05:49 PM, Colin King wrote:
> From: Colin Ian King <[email protected]>
>
> Variable real_size is initialized with a value that is never read,
> it is re-assigned a new value later on, hence the initialization is
> redundant and can be removed.
>
> Cleans up clang warning:
> lib/test_kasan.c:422:21: warning: Value stored to 'real_size' during
> its initialization is never read
>
> Signed-off-by: Colin Ian King <[email protected]>

Acked-by: Andrey Ryabinin <[email protected]>

> ---
> lib/test_kasan.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/lib/test_kasan.c b/lib/test_kasan.c
> index a808d81b409d..dba0ffd45fd7 100644
> --- a/lib/test_kasan.c
> +++ b/lib/test_kasan.c
> @@ -419,7 +419,7 @@ static noinline void __init kasan_stack_oob(void)
> static noinline void __init ksize_unpoisons_memory(void)
> {
> char *ptr;
> - size_t size = 123, real_size = size;
> + size_t size = 123, real_size;
>
> pr_info("ksize() unpoisons the whole allocated chunk\n");
> ptr = kmalloc(size, GFP_KERNEL);
>