2018-01-03 03:03:27

by Wei Yongjun

[permalink] [raw]
Subject: [PATCH -next] drm/panel: ili9322:Make local symbols static

Fixes the following sparse warnings:

drivers/gpu/drm/panel/panel-ilitek-ili9322.c:182:12: warning:
symbol 'ili9322_inputs' was not declared. Should it be static?
drivers/gpu/drm/panel/panel-ilitek-ili9322.c:343:28: warning:
symbol 'ili9322_regmap_config' was not declared. Should it be static?

Also change ili9322_inputs to 'const char * const' to avoid
chackpatch warning.

Signed-off-by: Wei Yongjun <[email protected]>
---
drivers/gpu/drm/panel/panel-ilitek-ili9322.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/gpu/drm/panel/panel-ilitek-ili9322.c b/drivers/gpu/drm/panel/panel-ilitek-ili9322.c
index b4ec0ec..bd38bf4 100644
--- a/drivers/gpu/drm/panel/panel-ilitek-ili9322.c
+++ b/drivers/gpu/drm/panel/panel-ilitek-ili9322.c
@@ -179,7 +179,7 @@ enum ili9322_input {
ILI9322_INPUT_UNKNOWN = 0xc,
};

-const char *ili9322_inputs[] = {
+static const char * const ili9322_inputs[] = {
"8 bit serial RGB through",
"8 bit serial RGB aligned",
"8 bit serial RGB dummy 320x240",
@@ -340,7 +340,7 @@ static bool ili9322_writeable_reg(struct device *dev, unsigned int reg)
return true;
}

-const struct regmap_config ili9322_regmap_config = {
+static const struct regmap_config ili9322_regmap_config = {
.reg_bits = 8,
.val_bits = 8,
.max_register = 0x44,


2018-03-12 09:08:40

by Thierry Reding

[permalink] [raw]
Subject: Re: [PATCH -next] drm/panel: ili 9322:Make local symbols static

On Wed, Jan 03, 2018 at 03:08:58AM +0000, Wei Yongjun wrote:
> Fixes the following sparse warnings:
>
> drivers/gpu/drm/panel/panel-ilitek-ili9322.c:182:12: warning:
> symbol 'ili9322_inputs' was not declared. Should it be static?
> drivers/gpu/drm/panel/panel-ilitek-ili9322.c:343:28: warning:
> symbol 'ili9322_regmap_config' was not declared. Should it be static?
>
> Also change ili9322_inputs to 'const char * const' to avoid
> chackpatch warning.
>
> Signed-off-by: Wei Yongjun <[email protected]>
> ---
> drivers/gpu/drm/panel/panel-ilitek-ili9322.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)

Applied, thanks.

Thierry


Attachments:
(No filename) (674.00 B)
signature.asc (849.00 B)
Download all attachments