LinuxLists.cc - [PATCH] i2c: at91: Read all available bytes at once

2018-04-18 12:51:49

Subject: [PATCH] i2c: at91: Read all available bytes at once

With FIFO enabled it is possible to read multiple bytes
at once in the interrupt handler as long as RXRDY is
set. This may also reduce the number of interrupts.

Signed-off-by: David Engraf <[email protected]>
---
drivers/i2c/busses/i2c-at91.c | 8 ++++++--
1 file changed, 6 insertions(+), 2 deletions(-)

diff --git a/drivers/i2c/busses/i2c-at91.c b/drivers/i2c/busses/i2c-at91.c
index bfd1fdff64a9..d01c2b2384bd 100644
--- a/drivers/i2c/busses/i2c-at91.c
+++ b/drivers/i2c/busses/i2c-at91.c
@@ -518,8 +518,12 @@ static irqreturn_t atmel_twi_interrupt(int irq, void *dev_id)
* the RXRDY interrupt first in order to not keep garbage data in the
* Receive Holding Register for the next transfer.
*/
- if (irqstatus & AT91_TWI_RXRDY)
- at91_twi_read_next_byte(dev);
+ if (irqstatus & AT91_TWI_RXRDY) {
+ /* read all available bytes at once when FIFO is used */
+ do {
+ at91_twi_read_next_byte(dev);
+ } while (at91_twi_read(dev, AT91_TWI_SR) & AT91_TWI_RXRDY);
+ }

/*
* When a NACK condition is detected, the I2C controller sets the NACK,
--
2.14.1

2018-04-25 15:11:47

by Ludovic Desroches

[permalink] [raw]

Subject: Re: [PATCH] i2c: at91: Read all available bytes at once

Hi David,

On Wed, Apr 18, 2018 at 02:40:55PM +0200, David Engraf wrote:
> With FIFO enabled it is possible to read multiple bytes
> at once in the interrupt handler as long as RXRDY is
> set. This may also reduce the number of interrupts.
>
> Signed-off-by: David Engraf <[email protected]>
> ---
> drivers/i2c/busses/i2c-at91.c | 8 ++++++--
> 1 file changed, 6 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/i2c/busses/i2c-at91.c b/drivers/i2c/busses/i2c-at91.c
> index bfd1fdff64a9..d01c2b2384bd 100644
> --- a/drivers/i2c/busses/i2c-at91.c
> +++ b/drivers/i2c/busses/i2c-at91.c
> @@ -518,8 +518,12 @@ static irqreturn_t atmel_twi_interrupt(int irq, void *dev_id)
> * the RXRDY interrupt first in order to not keep garbage data in the
> * Receive Holding Register for the next transfer.
> */
> - if (irqstatus & AT91_TWI_RXRDY)
> - at91_twi_read_next_byte(dev);
> + if (irqstatus & AT91_TWI_RXRDY) {
> + /* read all available bytes at once when FIFO is used */
> + do {
> + at91_twi_read_next_byte(dev);
> + } while (at91_twi_read(dev, AT91_TWI_SR) & AT91_TWI_RXRDY);

You can avoid this check by using the RXFL field to know the number of
data you can read. Did you try to use it? If yes, did you notice some issues?

Regards

Ludovic

> + }
>
> /*
> * When a NACK condition is detected, the I2C controller sets the NACK,
> --
> 2.14.1
>

2018-04-25 15:45:05

by David Engraf

[permalink] [raw]

Subject: Re: [PATCH] i2c: at91: Read all available bytes at once

2018-04-26 05:53:40

by David Engraf

[permalink] [raw]

Subject: Re: [PATCH] i2c: at91: Read all available bytes at once

Hi Ludovic,

Am 25.04.2018 um 17:08 schrieb Ludovic Desroches:
> Hi David,
>
> On Wed, Apr 18, 2018 at 02:40:55PM +0200, David Engraf wrote:
>> With FIFO enabled it is possible to read multiple bytes
>> at once in the interrupt handler as long as RXRDY is
>> set. This may also reduce the number of interrupts.
>>
>> Signed-off-by: David Engraf <[email protected]>
>> ---
>> drivers/i2c/busses/i2c-at91.c | 8 ++++++--
>> 1 file changed, 6 insertions(+), 2 deletions(-)
>>
>> diff --git a/drivers/i2c/busses/i2c-at91.c b/drivers/i2c/busses/i2c-at91.c
>> index bfd1fdff64a9..d01c2b2384bd 100644
>> --- a/drivers/i2c/busses/i2c-at91.c
>> +++ b/drivers/i2c/busses/i2c-at91.c
>> @@ -518,8 +518,12 @@ static irqreturn_t atmel_twi_interrupt(int irq, void *dev_id)
>> * the RXRDY interrupt first in order to not keep garbage data in the
>> * Receive Holding Register for the next transfer.
>> */
>> - if (irqstatus & AT91_TWI_RXRDY)
>> - at91_twi_read_next_byte(dev);
>> + if (irqstatus & AT91_TWI_RXRDY) {
>> + /* read all available bytes at once when FIFO is used */
>> + do {
>> + at91_twi_read_next_byte(dev);
>> + } while (at91_twi_read(dev, AT91_TWI_SR) & AT91_TWI_RXRDY);
>
> You can avoid this check by using the RXFL field to know the number of
> data you can read. Did you try to use it? If yes, did you notice some issues?

I did a quick test by reading RXFL and it worked as well but I decided
to use the more readable solution by polling RXRDY. Also I don't need to
check if the FIFO has been enabled.

If you prefer using RXFL I can create a new patch.

Best regards
- David

> Regards
>
> Ludovic
>
>> + }
>>
>> /*
>> * When a NACK condition is detected, the I2C controller sets the NACK,
>> --
>> 2.14.1
>>

--
Mit freundlichen Grüßen/Best regards,

David Engraf
Product Engineer

SYSGO AG
Office Mainz
Am Pfaffenstein 14 / D-55270 Klein-Winternheim / Germany

Phone: +49-6136-9948-0 / Fax: +49-6136-9948-10
E-mail: [email protected]
_________________________________________________________________________________

Web: https://www.sysgo.com
Blog: https://www.sysgo.com/blog
Events: https://www.sysgo.com/events
Newsletter: https://www.sysgo.com/newsletter
_________________________________________________________________________________

Handelsregister/Commercial Registry: HRB Mainz 90 HRB 8066
Vorstand/Executive Board: Etienne Butery (CEO), Kai Sablotny (COO)
Aufsichtsratsvorsitzender/Supervisory Board Chairman: Marc Darmon
USt-Id-Nr./VAT-Id-No.: DE 149062328

2018-04-26 08:28:10

by Ludovic Desroches

[permalink] [raw]

Subject: Re: [PATCH] i2c: at91: Read all available bytes at once

Hi David,

On Wed, Apr 25, 2018 at 05:43:09PM +0200, David Engraf wrote:
> Hi Ludovic,
>
> Am 25.04.2018 um 17:08 schrieb Ludovic Desroches:
> > Hi David,
> >
> > On Wed, Apr 18, 2018 at 02:40:55PM +0200, David Engraf wrote:
> > > With FIFO enabled it is possible to read multiple bytes
> > > at once in the interrupt handler as long as RXRDY is
> > > set. This may also reduce the number of interrupts.
> > >
> > > Signed-off-by: David Engraf <[email protected]>
> > > ---
> > > drivers/i2c/busses/i2c-at91.c | 8 ++++++--
> > > 1 file changed, 6 insertions(+), 2 deletions(-)
> > >
> > > diff --git a/drivers/i2c/busses/i2c-at91.c b/drivers/i2c/busses/i2c-at91.c
> > > index bfd1fdff64a9..d01c2b2384bd 100644
> > > --- a/drivers/i2c/busses/i2c-at91.c
> > > +++ b/drivers/i2c/busses/i2c-at91.c
> > > @@ -518,8 +518,12 @@ static irqreturn_t atmel_twi_interrupt(int irq, void *dev_id)
> > > * the RXRDY interrupt first in order to not keep garbage data in the
> > > * Receive Holding Register for the next transfer.
> > > */
> > > - if (irqstatus & AT91_TWI_RXRDY)
> > > - at91_twi_read_next_byte(dev);
> > > + if (irqstatus & AT91_TWI_RXRDY) {
> > > + /* read all available bytes at once when FIFO is used */
> > > + do {
> > > + at91_twi_read_next_byte(dev);
> > > + } while (at91_twi_read(dev, AT91_TWI_SR) & AT91_TWI_RXRDY);
> >
> > You can avoid this check by using the RXFL field to know the number of
> > data you can read. Did you try to use it? If yes, did you notice some issues?
>
> I did a quick test by reading RXFL and it worked as well but I decided to
> use the more readable solution by polling RXRDY. Also I don't need to check
> if the FIFO has been enabled.
>
> If you prefer using RXFL I can create a new patch.

Honestly, I have no strong opinion about it. As you said you approach is
simple and easy to read.

About performances, I assume that both solutions are pretty the same for
small number of data. If the number increases, using the RXFL field
should give better results.

So I would say, maybe add a note in the commit log or in the code to
keep in mind there is this solution to go further.

Otherwise
Acked-by: Ludovic Desroches <[email protected]>

Regards

Ludovic

>
> Best regards
> - David
>
>
> > Regards
> >
> > Ludovic
> >
> > > + }
> > > /*
> > > * When a NACK condition is detected, the I2C controller sets the NACK,
> > > --
> > > 2.14.1
> > >
>

2018-04-26 09:56:02

by David Engraf

[permalink] [raw]

Subject: [PATCH v2] i2c: at91: Read all available bytes at once

With FIFO enabled it is possible to read multiple bytes
at once in the interrupt handler as long as RXRDY is
set. This may also reduce the number of interrupts.

This patch polls RXRDY and reads all available bytes at
once.

Signed-off-by: David Engraf <[email protected]>
---
drivers/i2c/busses/i2c-at91.c | 12 ++++++++++--
1 file changed, 10 insertions(+), 2 deletions(-)

diff --git a/drivers/i2c/busses/i2c-at91.c b/drivers/i2c/busses/i2c-at91.c
index bfd1fdff64a9..9caee5b79eac 100644
--- a/drivers/i2c/busses/i2c-at91.c
+++ b/drivers/i2c/busses/i2c-at91.c
@@ -518,8 +518,16 @@ static irqreturn_t atmel_twi_interrupt(int irq, void *dev_id)
* the RXRDY interrupt first in order to not keep garbage data in the
* Receive Holding Register for the next transfer.
*/
- if (irqstatus & AT91_TWI_RXRDY)
- at91_twi_read_next_byte(dev);
+ if (irqstatus & AT91_TWI_RXRDY) {
+ /*
+ * Read all available bytes at once by polling RXRDY usable w/ and w/o
+ * FIFO. With FIFO enabled we could also read RXFL and avoid polling
+ * RXRDY.
+ */
+ do {
+ at91_twi_read_next_byte(dev);
+ } while (at91_twi_read(dev, AT91_TWI_SR) & AT91_TWI_RXRDY);
+ }

/*
* When a NACK condition is detected, the I2C controller sets the NACK,
--
2.14.1

2018-04-26 12:33:12

by Ludovic Desroches

[permalink] [raw]

Subject: Re: [PATCH v2] i2c: at91: Read all available bytes at once

On Thu, Apr 26, 2018 at 11:53:14AM +0200, David Engraf wrote:
> With FIFO enabled it is possible to read multiple bytes
> at once in the interrupt handler as long as RXRDY is
> set. This may also reduce the number of interrupts.
>
> This patch polls RXRDY and reads all available bytes at
> once.
>
> Signed-off-by: David Engraf <[email protected]>
Acked-by: Ludovic Desroches <[email protected]>

Thanks a lot David.

Regards

Ludovic

> ---
> drivers/i2c/busses/i2c-at91.c | 12 ++++++++++--
> 1 file changed, 10 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/i2c/busses/i2c-at91.c b/drivers/i2c/busses/i2c-at91.c
> index bfd1fdff64a9..9caee5b79eac 100644
> --- a/drivers/i2c/busses/i2c-at91.c
> +++ b/drivers/i2c/busses/i2c-at91.c
> @@ -518,8 +518,16 @@ static irqreturn_t atmel_twi_interrupt(int irq, void *dev_id)
> * the RXRDY interrupt first in order to not keep garbage data in the
> * Receive Holding Register for the next transfer.
> */
> - if (irqstatus & AT91_TWI_RXRDY)
> - at91_twi_read_next_byte(dev);
> + if (irqstatus & AT91_TWI_RXRDY) {
> + /*
> + * Read all available bytes at once by polling RXRDY usable w/ and w/o
> + * FIFO. With FIFO enabled we could also read RXFL and avoid polling
> + * RXRDY.
> + */
> + do {
> + at91_twi_read_next_byte(dev);
> + } while (at91_twi_read(dev, AT91_TWI_SR) & AT91_TWI_RXRDY);
> + }
>
> /*
> * When a NACK condition is detected, the I2C controller sets the NACK,
> --
> 2.14.1
>

2018-04-28 12:40:00

by Wolfram Sang

[permalink] [raw]

Subject: Re: [PATCH v2] i2c: at91: Read all available bytes at once

Attachments:

(No filename) (625.00 B)
signature.asc (849.00 B)
Download all attachments

2018-04-30 06:11:42

by David Engraf

[permalink] [raw]

Subject: Re: [PATCH v2] i2c: at91: Read all available bytes at once

Am 28.04.2018 um 14:38 schrieb Wolfram Sang:
> On Thu, Apr 26, 2018 at 11:53:14AM +0200, David Engraf wrote:
>> With FIFO enabled it is possible to read multiple bytes
>> at once in the interrupt handler as long as RXRDY is
>> set. This may also reduce the number of interrupts.
>>
>> This patch polls RXRDY and reads all available bytes at
>> once.
>>
>> Signed-off-by: David Engraf <[email protected]>
>
> checkpatch said twice:
>
> WARNING: line over 80 characters
>
> While I am not super-strict with this limit, it makes sense here IMO.
> The comment stays readable, and we don't even lose a line.

Sorry for that.

> Fixed it this time for you.

Thanks
- David

> Applied to for-next, thanks!
>