2018-05-22 10:13:50

by Yangbo Lu

Subject: PTP clock driver for FSL DPAA

Hi Richard,

I'm going to make a PTP clock driver patch for FSL DPAA ethernet controller. (drivers/net/ethernet/freescale/dpaa/)
Actually the 1588 timer module on FSL DPAA is same with the one on FSL eTSEC in hardware.(whose PTP clock driver is drivers/net/ethernet/freescale/gianfar_ptp.c)

So there are two options for me I think.
Option #1, just make a dpaa_ptp.c driver which will be almost same with gianfar_ptp.c.
Option #2, try to reuse gianfar_ptp.c driver by reworking it as a common driver, renaming it, and putting it to a common place (drivers/ptp/ or still drivers/net/ethernet/freescale/).

I'd like to ask your suggestion.
Thanks a lot.

Best regards,
Yangbo Lu

2018-05-22 14:37:55

by Richard Cochran

Subject: Re: PTP clock driver for FSL DPAA

On Tue, May 22, 2018 at 10:07:20AM +0000, Y.b. Lu wrote:
> I'm going to make a PTP clock driver patch for FSL DPAA ethernet controller. (drivers/net/ethernet/freescale/dpaa/)
> Actually the 1588 timer module on FSL DPAA is same with the one on FSL eTSEC in hardware.(whose PTP clock driver is drivers/net/ethernet/freescale/gianfar_ptp.c)
>
> So there are two options for me I think.
> Option #1, just make a dpaa_ptp.c driver which will be almost same with gianfar_ptp.c.
> Option #2, try to reuse gianfar_ptp.c driver by reworking it as a common driver, renaming it, and putting it to a common place (drivers/ptp/ or still drivers/net/ethernet/freescale/).

If you can make it work, #2 sounds like the best solution.

Thanks,
Richard