2018-06-12 14:52:04

by Srinivas Kandagatla

[permalink] [raw]
Subject: [PATCH] arm64: dts: apq8096-db820c: disable uart0 by default

Access to UART0 is disabled by bootloaders. By leaving it enabled by
default would reboot the board.
Disable this for now, this would alteast give a board which boots.

Signed-off-by: Srinivas Kandagatla <[email protected]>
---
arch/arm64/boot/dts/qcom/apq8096-db820c.dtsi | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/arm64/boot/dts/qcom/apq8096-db820c.dtsi b/arch/arm64/boot/dts/qcom/apq8096-db820c.dtsi
index 0f829db33efe..4d5ef01f43a3 100644
--- a/arch/arm64/boot/dts/qcom/apq8096-db820c.dtsi
+++ b/arch/arm64/boot/dts/qcom/apq8096-db820c.dtsi
@@ -75,7 +75,7 @@

serial@75b1000 {
label = "LS-UART0";
- status = "okay";
+ status = "disabled";
pinctrl-names = "default", "sleep";
pinctrl-0 = <&blsp2_uart2_4pins_default>;
pinctrl-1 = <&blsp2_uart2_4pins_sleep>;
--
2.16.2



2018-06-12 15:49:01

by Bjorn Andersson

[permalink] [raw]
Subject: Re: [PATCH] arm64: dts: apq8096-db820c: disable uart0 by default

On Tue 12 Jun 07:48 PDT 2018, Srinivas Kandagatla wrote:

> Access to UART0 is disabled by bootloaders. By leaving it enabled by
> default would reboot the board.
> Disable this for now, this would alteast give a board which boots.
>
> Signed-off-by: Srinivas Kandagatla <[email protected]>

Reviewed-by: Bjorn Andersson <[email protected]>

Regards,
Bjorn

> ---
> arch/arm64/boot/dts/qcom/apq8096-db820c.dtsi | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/arm64/boot/dts/qcom/apq8096-db820c.dtsi b/arch/arm64/boot/dts/qcom/apq8096-db820c.dtsi
> index 0f829db33efe..4d5ef01f43a3 100644
> --- a/arch/arm64/boot/dts/qcom/apq8096-db820c.dtsi
> +++ b/arch/arm64/boot/dts/qcom/apq8096-db820c.dtsi
> @@ -75,7 +75,7 @@
>
> serial@75b1000 {
> label = "LS-UART0";
> - status = "okay";
> + status = "disabled";
> pinctrl-names = "default", "sleep";
> pinctrl-0 = <&blsp2_uart2_4pins_default>;
> pinctrl-1 = <&blsp2_uart2_4pins_sleep>;
> --
> 2.16.2
>

2018-06-13 07:23:21

by Andy Gross

[permalink] [raw]
Subject: Re: [PATCH] arm64: dts: apq8096-db820c: disable uart0 by default

On Tue, Jun 12, 2018 at 03:48:06PM +0100, Srinivas Kandagatla wrote:
> Access to UART0 is disabled by bootloaders. By leaving it enabled by
> default would reboot the board.
> Disable this for now, this would alteast give a board which boots.
>
> Signed-off-by: Srinivas Kandagatla <[email protected]>

Thanks for this patch. I'll queue it up for a fixes-for-rc1


Andy