2018-07-15 08:53:49

by Raghu Halharvi

Subject: [PATCH] ks7010_sdio:Fix checkpatch out of memory warning

* Patch fixes checkpatch warning "Possible unnecessary 'out of memory'
message"

Signed-off-by: RAGHU Halharvi <[email protected]>
---
drivers/staging/ks7010/ks7010_sdio.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/drivers/staging/ks7010/ks7010_sdio.c b/drivers/staging/ks7010/ks7010_sdio.c
index b8f55a11ee1c..972b01a0257d 100644
--- a/drivers/staging/ks7010/ks7010_sdio.c
+++ b/drivers/staging/ks7010/ks7010_sdio.c
@@ -957,10 +957,8 @@ static int send_stop_request(struct sdio_func *func)
card = sdio_get_drvdata(func);

pp = kzalloc(hif_align_size(sizeof(*pp)), GFP_KERNEL);
- if (!pp) {
- netdev_err(card->priv->net_dev, "allocate memory failed..\n");
+ if (!pp)
return -ENOMEM;
- }

size = sizeof(*pp) - sizeof(pp->header.size);
pp->header.size = cpu_to_le16((uint16_t)size);
--
2.17.1

2018-07-16 10:03:37

by Greg Kroah-Hartman

Subject: Re: [PATCH] ks7010_sdio:Fix checkpatch out of memory warning

On Fri, Jul 13, 2018 at 09:36:36PM +0530, RAGHU Halharvi wrote:
> * Patch fixes checkpatch warning "Possible unnecessary 'out of memory'
> message"
>
> Signed-off-by: RAGHU Halharvi <[email protected]>

Next time please put "staging:" in the subject line, as a prefix, like
all other patches for this driver have.

thanks,

greg k-h

2018-07-16 10:04:37

by Greg Kroah-Hartman

Subject: Re: [PATCH] staging: ks7010_sdio:Fix checkpatch out of memory warning

On Fri, Jul 13, 2018 at 09:36:36PM +0530, RAGHU Halharvi wrote:
> * Patch fixes checkpatch warning "Possible unnecessary 'out of memory'
> message"
>
> Signed-off-by: RAGHU Halharvi <[email protected]>
> ---
> drivers/staging/ks7010/ks7010_sdio.c | 4 +---
> 1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/drivers/staging/ks7010/ks7010_sdio.c b/drivers/staging/ks7010/ks7010_sdio.c
> index b8f55a11ee1c..972b01a0257d 100644
> --- a/drivers/staging/ks7010/ks7010_sdio.c
> +++ b/drivers/staging/ks7010/ks7010_sdio.c
> @@ -957,10 +957,8 @@ static int send_stop_request(struct sdio_func *func)
> card = sdio_get_drvdata(func);
>
> pp = kzalloc(hif_align_size(sizeof(*pp)), GFP_KERNEL);
> - if (!pp) {
> - netdev_err(card->priv->net_dev, "allocate memory failed..\n");
> + if (!pp)
> return -ENOMEM;
> - }

This change has already been done in my tree, please always work against
linux-next at the least, and ideally staging.git, so that you do not
duplicate work others have already done.

thanks,

greg k-h