2018-07-17 20:25:50

by Arnd Bergmann

Subject: [PATCH] security: export security_kernel_load_data function

The firmware_loader can be built as a loadable module, which now
fails when CONFIG_SECURITY is enabled, because a call to the
security_kernel_load_data() function got added, and this is
not exported to modules:

ERROR: "security_kernel_load_data" [drivers/base/firmware_loader/firmware_class.ko] undefined!

Add an EXPORT_SYMBOL_GPL() to make it available here.

Fixes: 6e852651f28e ("firmware: add call to LSM hook before firmware sysfs fallback")
Signed-off-by: Arnd Bergmann <[email protected]>
---
security/security.c | 1 +
1 file changed, 1 insertion(+)

diff --git a/security/security.c b/security/security.c
index 03e98be76d58..7f9618eaba10 100644
--- a/security/security.c
+++ b/security/security.c
@@ -1121,6 +1121,7 @@ int security_kernel_load_data(enum kernel_load_data_id id)
return ret;
return ima_load_data(id);
}
+EXPORT_SYMBOL_GPL(security_kernel_load_data);

int security_task_fix_setuid(struct cred *new, const struct cred *old,
int flags)
--
2.9.0

2018-07-18 04:29:28

by James Morris

Subject: Re: [PATCH] security: export security_kernel_load_data function

On Tue, 17 Jul 2018, Arnd Bergmann wrote:

> The firmware_loader can be built as a loadable module, which now
> fails when CONFIG_SECURITY is enabled, because a call to the
> security_kernel_load_data() function got added, and this is
> not exported to modules:
>
> ERROR: "security_kernel_load_data" [drivers/base/firmware_loader/firmware_class.ko] undefined!
>
> Add an EXPORT_SYMBOL_GPL() to make it available here.
>
> Fixes: 6e852651f28e ("firmware: add call to LSM hook before firmware sysfs fallback")
> Signed-off-by: Arnd Bergmann <[email protected]>

Thanks!

Applied to
git://git.kernel.org/pub/scm/linux/kernel/git/jmorris/linux-security.git next-general


--
James Morris
<[email protected]>