2018-07-27 08:35:44

by Jia-Ju Bai

Subject: [PATCH] net: phy: marvell: Replace mdelay() with msleep() in m88e1116r_config_init()

m88e1116r_config_init() is never called in atomic context.
It calls mdelay() to busily wait, which is not necessary.
mdelay() can be replaced with msleep().

This is found by a static analysis tool named DCNS written by myself.

Signed-off-by: Jia-Ju Bai <[email protected]>
---
drivers/net/phy/marvell.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/net/phy/marvell.c b/drivers/net/phy/marvell.c
index 25e2a099b71c..ed04346df235 100644
--- a/drivers/net/phy/marvell.c
+++ b/drivers/net/phy/marvell.c
@@ -646,7 +646,7 @@ static int m88e1116r_config_init(struct phy_device *phydev)
if (err < 0)
return err;

- mdelay(500);
+ msleep(500);

err = marvell_set_page(phydev, MII_MARVELL_COPPER_PAGE);
if (err < 0)
--
2.17.0

2018-07-27 13:32:13

by Andrew Lunn

Subject: Re: [PATCH] net: phy: marvell: Replace mdelay() with msleep() in m88e1116r_config_init()

On Fri, Jul 27, 2018 at 04:34:25PM +0800, Jia-Ju Bai wrote:
> m88e1116r_config_init() is never called in atomic context.
> It calls mdelay() to busily wait, which is not necessary.
> mdelay() can be replaced with msleep().
>
> This is found by a static analysis tool named DCNS written by myself.
>
> Signed-off-by: Jia-Ju Bai <[email protected]>

Reviewed-by: Andrew Lunn <[email protected]>

Andrew

2018-07-27 21:14:08

by David Miller

Subject: Re: [PATCH] net: phy: marvell: Replace mdelay() with msleep() in m88e1116r_config_init()

From: Jia-Ju Bai <[email protected]>
Date: Fri, 27 Jul 2018 16:34:25 +0800

> m88e1116r_config_init() is never called in atomic context.
> It calls mdelay() to busily wait, which is not necessary.
> mdelay() can be replaced with msleep().
>
> This is found by a static analysis tool named DCNS written by myself.
>
> Signed-off-by: Jia-Ju Bai <[email protected]>

Applied.