2018-07-27 16:09:21

by Nishad Kamdar

[permalink] [raw]

Subject: [PATCH] staging: mt7621-mmc: Use BIT macro instead of explicit shifting in board.h

---

Replace explicit shifting with BIT macro in board.h.
Issue found by checkpatch.

Signed-off-by: Nishad Kamdar <[email protected]>
---
drivers/staging/mt7621-mmc/board.h | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/drivers/staging/mt7621-mmc/board.h b/drivers/staging/mt7621-mmc/board.h
index a7d82f321b00..983791ee308d 100644
--- a/drivers/staging/mt7621-mmc/board.h
+++ b/drivers/staging/mt7621-mmc/board.h
@@ -36,10 +36,10 @@
#ifndef __ARCH_ARM_MACH_BOARD_H
#define __ARCH_ARM_MACH_BOARD_H

-#define MSDC_CD_PIN_EN (1 << 0) /* card detection pin is wired */
-#define MSDC_WP_PIN_EN (1 << 1) /* write protection pin is wired */
-#define MSDC_RST_PIN_EN (1 << 2) /* emmc reset pin is wired */
-#define MSDC_REMOVABLE (1 << 5) /* removable slot */
+#define MSDC_CD_PIN_EN BIT(0) /* card detection pin is wired */
+#define MSDC_WP_PIN_EN BIT(1) /* write protection pin is wired */
+#define MSDC_RST_PIN_EN BIT(2) /* emmc reset pin is wired */
+#define MSDC_REMOVABLE BIT(5) /* removable slot */

#define MSDC_SMPL_RISING (0)
#define MSDC_SMPL_FALLING (1)
--
2.17.1

2018-07-30 22:12:26

by NeilBrown

[permalink] [raw]

Subject: Re: [PATCH] staging: mt7621-mmc: Use BIT macro instead of explicit shifting in board.h

---

On Fri, Jul 27 2018, Nishad Kamdar wrote:

> Replace explicit shifting with BIT macro in board.h.
> Issue found by checkpatch.
>
> Signed-off-by: Nishad Kamdar <[email protected]>

Reviewed-by: NeilBrown <[email protected]>

Thanks,
NeilBrown

> ---
> drivers/staging/mt7621-mmc/board.h | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/staging/mt7621-mmc/board.h b/drivers/staging/mt7621-mmc/board.h
> index a7d82f321b00..983791ee308d 100644
> --- a/drivers/staging/mt7621-mmc/board.h
> +++ b/drivers/staging/mt7621-mmc/board.h
> @@ -36,10 +36,10 @@
> #ifndef __ARCH_ARM_MACH_BOARD_H
> #define __ARCH_ARM_MACH_BOARD_H
>
> -#define MSDC_CD_PIN_EN (1 << 0) /* card detection pin is wired */
> -#define MSDC_WP_PIN_EN (1 << 1) /* write protection pin is wired */
> -#define MSDC_RST_PIN_EN (1 << 2) /* emmc reset pin is wired */
> -#define MSDC_REMOVABLE (1 << 5) /* removable slot */
> +#define MSDC_CD_PIN_EN BIT(0) /* card detection pin is wired */
> +#define MSDC_WP_PIN_EN BIT(1) /* write protection pin is wired */
> +#define MSDC_RST_PIN_EN BIT(2) /* emmc reset pin is wired */
> +#define MSDC_REMOVABLE BIT(5) /* removable slot */
>
> #define MSDC_SMPL_RISING (0)
> #define MSDC_SMPL_FALLING (1)
> --
> 2.17.1

---

Attachments:

signature.asc (847.00 B)