2018-07-28 09:04:13

by Sohil Ladhani

Subject: [PATCH] net: ethernet: realtek: r8169: Add spaces after commas coding style issue

Fixed a coding style issue

Signed-off-by: Sohil Ladhani <[email protected]>
---
drivers/net/ethernet/realtek/r8169.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/net/ethernet/realtek/r8169.c b/drivers/net/ethernet/realtek/r8169.c
index f4cae2be0fda..e4754f336c34 100644
--- a/drivers/net/ethernet/realtek/r8169.c
+++ b/drivers/net/ethernet/realtek/r8169.c
@@ -61,7 +61,7 @@
#define assert(expr) \
if (!(expr)) { \
printk( "Assertion failed! %s,%s,%s,line=%d\n", \
- #expr,__FILE__,__func__,__LINE__); \
+ #expr, __FILE__, __func__, __LINE__); \
}
#define dprintk(fmt, args...) \
do { printk(KERN_DEBUG PFX fmt, ## args); } while (0)
--
2.18.0

2018-07-29 20:19:19

by David Miller

Subject: Re: [PATCH] net: ethernet: realtek: r8169: Add spaces after commas coding style issue

From: Sohil Ladhani <[email protected]>
Date: Sat, 28 Jul 2018 14:32:21 +0530

> Fixed a coding style issue
>
> Signed-off-by: Sohil Ladhani <[email protected]>

This doesn't apply to the current net-next tree.

2018-07-31 09:44:14

by Sohil Ladhani

Subject: Re: [PATCH] net: ethernet: realtek: r8169: Add spaces after commas coding style issue

Hi David. Thanks for your inputs. I'm a kernel newbie and was just
following Greg's FOSDEM talk to submit my first patch. Will submit
further patches to net-next tree.

On Mon, Jul 30, 2018 at 1:47 AM, David Miller <[email protected]> wrote:
> From: Sohil Ladhani <[email protected]>
> Date: Sat, 28 Jul 2018 14:32:21 +0530
>
>> Fixed a coding style issue
>>
>> Signed-off-by: Sohil Ladhani <[email protected]>
>
> This doesn't apply to the current net-next tree.