2018-08-05 00:33:09

by Gustavo A. R. Silva

Subject: [PATCH] xen-blkfront: use true and false for boolean values

Return statements in functions returning bool should use true or false
instead of an integer value.

This code was detected with the help of Coccinelle.

Signed-off-by: Gustavo A. R. Silva <[email protected]>
---
drivers/block/xen-blkfront.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/block/xen-blkfront.c b/drivers/block/xen-blkfront.c
index 94300db..8986ada 100644
--- a/drivers/block/xen-blkfront.c
+++ b/drivers/block/xen-blkfront.c
@@ -1436,7 +1436,7 @@ static bool blkif_completion(unsigned long *id,

/* Wait the second response if not yet here. */
if (s2->status == REQ_WAITING)
- return 0;
+ return false;

bret->status = blkif_get_final_status(s->status,
s2->status);
@@ -1537,7 +1537,7 @@ static bool blkif_completion(unsigned long *id,
}
}

- return 1;
+ return true;
}

static irqreturn_t blkif_interrupt(int irq, void *dev_id)
--
2.7.4

2018-08-06 09:18:45

by Roger Pau Monne

Subject: Re: [PATCH] xen-blkfront: use true and false for boolean values

On Sat, Aug 04, 2018 at 07:08:59PM -0500, Gustavo A. R. Silva wrote:
> Return statements in functions returning bool should use true or false
> instead of an integer value.
>
> This code was detected with the help of Coccinelle.
>
> Signed-off-by: Gustavo A. R. Silva <[email protected]>

Acked-by: Roger Pau Monn? <[email protected]>

Thanks, Roger.

2018-08-06 15:08:38

by Jens Axboe

Subject: Re: [PATCH] xen-blkfront: use true and false for boolean values

On 8/4/18 6:08 PM, Gustavo A. R. Silva wrote:
> Return statements in functions returning bool should use true or false
> instead of an integer value.
>
> This code was detected with the help of Coccinelle.

Applied, thanks.

--
Jens Axboe