2018-09-04 14:17:21

by Colin King

Subject: [PATCH] mfd: arizona: make array mclk_name static, shrinks object size

From: Colin Ian King <[email protected]>

Don't populate the array mclk_name on the stack but instead make it
static. Makes the object code smaller by 23 bytes:

Before:
text data bss dec hex filename
38050 11604 64 49718 c236 linux/drivers/mfd/arizona-core.o

After:
text data bss dec hex filename
38027 11604 64 49695 c21f linux/drivers/mfd/arizona-core.o

(gcc version 8.2.0 x86_64)

Signed-off-by: Colin Ian King <[email protected]>
---
drivers/mfd/arizona-core.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/mfd/arizona-core.c b/drivers/mfd/arizona-core.c
index 5f1e37d23943..918d81a00b37 100644
--- a/drivers/mfd/arizona-core.c
+++ b/drivers/mfd/arizona-core.c
@@ -990,7 +990,7 @@ static const struct mfd_cell wm8998_devs[] = {

int arizona_dev_init(struct arizona *arizona)
{
- const char * const mclk_name[] = { "mclk1", "mclk2" };
+ static const char * const mclk_name[] = { "mclk1", "mclk2" };
struct device *dev = arizona->dev;
const char *type_name = NULL;
unsigned int reg, val;
--
2.17.1

2018-09-05 09:16:24

by Charles Keepax

Subject: Re: [PATCH] mfd: arizona: make array mclk_name static, shrinks object size

On Tue, Sep 04, 2018 at 03:15:53PM +0100, Colin King wrote:
> From: Colin Ian King <[email protected]>
>
> Don't populate the array mclk_name on the stack but instead make it
> static. Makes the object code smaller by 23 bytes:
>
> Before:
> text data bss dec hex filename
> 38050 11604 64 49718 c236 linux/drivers/mfd/arizona-core.o
>
> After:
> text data bss dec hex filename
> 38027 11604 64 49695 c21f linux/drivers/mfd/arizona-core.o
>
> (gcc version 8.2.0 x86_64)
>
> Signed-off-by: Colin Ian King <[email protected]>
> ---

Acked-by: Charles Keepax <[email protected]>

Thanks,
Charles

2018-09-11 14:01:42

by Lee Jones

Subject: Re: [PATCH] mfd: arizona: make array mclk_name static, shrinks object size

On Tue, 04 Sep 2018, Colin King wrote:

> From: Colin Ian King <[email protected]>
>
> Don't populate the array mclk_name on the stack but instead make it
> static. Makes the object code smaller by 23 bytes:
>
> Before:
> text data bss dec hex filename
> 38050 11604 64 49718 c236 linux/drivers/mfd/arizona-core.o
>
> After:
> text data bss dec hex filename
> 38027 11604 64 49695 c21f linux/drivers/mfd/arizona-core.o
>
> (gcc version 8.2.0 x86_64)
>
> Signed-off-by: Colin Ian King <[email protected]>
> ---
> drivers/mfd/arizona-core.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)

Applied, thanks.

--
Lee Jones [李琼斯]
Linaro Services Technical Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog