From: kbuild test robot <[email protected]>
drivers/power/supply/bq25890_charger.c:614:2-3: Unneeded semicolon
drivers/power/supply/bq25890_charger.c:621:2-3: Unneeded semicolon
drivers/power/supply/bq25890_charger.c:630:3-4: Unneeded semicolon
drivers/power/supply/bq25890_charger.c:638:2-3: Unneeded semicolon
drivers/power/supply/bq25890_charger.c:644:2-3: Unneeded semicolon
Remove unneeded semicolon.
Generated by: scripts/coccinelle/misc/semicolon.cocci
Fixes: 9d9ae3414d1b ("power: supply: bq25890_charger: Add debugging output of failed initialization")
CC: Angus Ainslie (Purism) <[email protected]>
Signed-off-by: kbuild test robot <[email protected]>
---
tree: https://git.kernel.org/pub/scm/linux/kernel/git/sre/linux-power-supply.git for-next
head: cb90a2c6f77fe9b43d1e3f759bb2f13fe7fa1811
commit: 9d9ae3414d1bb655d8db7079e56b0f51e7cd07f0 [4/13] power: supply: bq25890_charger: Add debugging output of failed initialization
bq25890_charger.c | 10 +++++-----
1 file changed, 5 insertions(+), 5 deletions(-)
--- a/drivers/power/supply/bq25890_charger.c
+++ b/drivers/power/supply/bq25890_charger.c
@@ -611,14 +611,14 @@ static int bq25890_hw_init(struct bq2589
if (ret < 0) {
dev_dbg(bq->dev, "Reset failed %d\n", ret);
return ret;
- };
+ }
/* disable watchdog */
ret = bq25890_field_write(bq, F_WD, 0);
if (ret < 0) {
dev_dbg(bq->dev, "Disabling watchdog failed %d\n", ret);
return ret;
- };
+ }
/* initialize currents/voltages and other parameters */
for (i = 0; i < ARRAY_SIZE(init_data); i++) {
@@ -627,7 +627,7 @@ static int bq25890_hw_init(struct bq2589
if (ret < 0) {
dev_dbg(bq->dev, "Writing init data failed %d\n", ret);
return ret;
- };
+ }
}
/* Configure ADC for continuous conversions. This does not enable it. */
@@ -635,13 +635,13 @@ static int bq25890_hw_init(struct bq2589
if (ret < 0) {
dev_dbg(bq->dev, "Config ADC failed %d\n", ret);
return ret;
- };
+ }
ret = bq25890_get_chip_state(bq, &state);
if (ret < 0) {
dev_dbg(bq->dev, "Get state failed %d\n", ret);
return ret;
- };
+ }
mutex_lock(&bq->lock);
bq->state = state;
Hi,
On Mon, Sep 17, 2018 at 10:23:20AM +0800, kbuild test robot wrote:
> From: kbuild test robot <[email protected]>
>
> drivers/power/supply/bq25890_charger.c:614:2-3: Unneeded semicolon
> drivers/power/supply/bq25890_charger.c:621:2-3: Unneeded semicolon
> drivers/power/supply/bq25890_charger.c:630:3-4: Unneeded semicolon
> drivers/power/supply/bq25890_charger.c:638:2-3: Unneeded semicolon
> drivers/power/supply/bq25890_charger.c:644:2-3: Unneeded semicolon
>
>
> Remove unneeded semicolon.
>
> Generated by: scripts/coccinelle/misc/semicolon.cocci
>
> Fixes: 9d9ae3414d1b ("power: supply: bq25890_charger: Add debugging output of failed initialization")
> CC: Angus Ainslie (Purism) <[email protected]>
> Signed-off-by: kbuild test robot <[email protected]>
> ---
Thanks, queued.
-- Sebastian
>
> tree: https://git.kernel.org/pub/scm/linux/kernel/git/sre/linux-power-supply.git for-next
> head: cb90a2c6f77fe9b43d1e3f759bb2f13fe7fa1811
> commit: 9d9ae3414d1bb655d8db7079e56b0f51e7cd07f0 [4/13] power: supply: bq25890_charger: Add debugging output of failed initialization
>
> bq25890_charger.c | 10 +++++-----
> 1 file changed, 5 insertions(+), 5 deletions(-)
>
> --- a/drivers/power/supply/bq25890_charger.c
> +++ b/drivers/power/supply/bq25890_charger.c
> @@ -611,14 +611,14 @@ static int bq25890_hw_init(struct bq2589
> if (ret < 0) {
> dev_dbg(bq->dev, "Reset failed %d\n", ret);
> return ret;
> - };
> + }
>
> /* disable watchdog */
> ret = bq25890_field_write(bq, F_WD, 0);
> if (ret < 0) {
> dev_dbg(bq->dev, "Disabling watchdog failed %d\n", ret);
> return ret;
> - };
> + }
>
> /* initialize currents/voltages and other parameters */
> for (i = 0; i < ARRAY_SIZE(init_data); i++) {
> @@ -627,7 +627,7 @@ static int bq25890_hw_init(struct bq2589
> if (ret < 0) {
> dev_dbg(bq->dev, "Writing init data failed %d\n", ret);
> return ret;
> - };
> + }
> }
>
> /* Configure ADC for continuous conversions. This does not enable it. */
> @@ -635,13 +635,13 @@ static int bq25890_hw_init(struct bq2589
> if (ret < 0) {
> dev_dbg(bq->dev, "Config ADC failed %d\n", ret);
> return ret;
> - };
> + }
>
> ret = bq25890_get_chip_state(bq, &state);
> if (ret < 0) {
> dev_dbg(bq->dev, "Get state failed %d\n", ret);
> return ret;
> - };
> + }
>
> mutex_lock(&bq->lock);
> bq->state = state;