2018-10-01 09:49:39

by Andrey Abramov

Subject: [PATCH] Staging: media: replaced deprecated probe method

Replaced i2c_driver::probe with i2c_driver::probe_new,
because documentation says that probe method is "soon to be deprecated".
And fixed problems of the previous attempt.

Signed-off-by: Andrey Abramov <[email protected]>
---
drivers/staging/media/bcm2048/radio-bcm2048.c | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)

diff --git a/drivers/staging/media/bcm2048/radio-bcm2048.c b/drivers/staging/media/bcm2048/radio-bcm2048.c
index a90b2eb112f9..6865e9fb6420 100644
--- a/drivers/staging/media/bcm2048/radio-bcm2048.c
+++ b/drivers/staging/media/bcm2048/radio-bcm2048.c
@@ -2574,8 +2574,7 @@ static const struct video_device bcm2048_viddev_template = {
/*
* I2C driver interface
*/
-static int bcm2048_i2c_driver_probe(struct i2c_client *client,
- const struct i2c_device_id *id)
+static int bcm2048_i2c_driver_probe(struct i2c_client *client)
{
struct bcm2048_device *bdev;
int err;
@@ -2679,7 +2678,7 @@ static struct i2c_driver bcm2048_i2c_driver = {
.driver = {
.name = BCM2048_DRIVER_NAME,
},
- .probe = bcm2048_i2c_driver_probe,
+ .probe_new = bcm2048_i2c_driver_probe,
.remove = bcm2048_i2c_driver_remove,
.id_table = bcm2048_id,
};
--
2.19.0

2018-10-01 09:52:54

by Dan Carpenter

Subject: Re: [PATCH] Staging: media: replaced deprecated probe method

On Mon, Oct 01, 2018 at 12:42:29PM +0300, Andrey Abramov wrote:
> Replaced i2c_driver::probe with i2c_driver::probe_new,
> because documentation says that probe method is "soon to be deprecated".
> And fixed problems of the previous attempt.

I'm sorry to complain again... Please, don't reference the "previous
attempt" in the commit message. The previous attempt is gone so no one
will remember what you are talking about after tomorrow. This is how
you resend a patch.

Change the subject to:

Subject: [PATCH v3] Staging: media: replace deprecated probe method

>
> Signed-off-by: Andrey Abramov <[email protected]>
> ---
> drivers/staging/media/bcm2048/radio-bcm2048.c | 5 ++---

Then right after the --- line put:

v3: fix commit message

That part of the commit message will be removed when we apply the patch.

regards,
dan carpenter