2018-10-23 11:15:23

by Denis Efremov (Oracle)

Subject: [PATCH] security: fix documentation for the task_setscheduler hook

From: Denis Efremov <[email protected]>

The task_setscheduler hook was changed in the commit
"security: remove unused parameter from security_task_setscheduler()"
(b0ae19811375). The arguments @policy, @lp were removed from the hook.
This patch updates the documentation accordingly.

Signed-off-by: Denis Efremov <[email protected]>
---
include/linux/lsm_hooks.h | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/include/linux/lsm_hooks.h b/include/linux/lsm_hooks.h
index accf6f34ac8e..ae3766720264 100644
--- a/include/linux/lsm_hooks.h
+++ b/include/linux/lsm_hooks.h
@@ -655,10 +655,8 @@
* Return 0 if permission is granted.
* @task_setscheduler:
* Check permission before setting scheduling policy and/or parameters of
- * process @p based on @policy and @lp.
+ * process @p.
* @p contains the task_struct for process.
- * @policy contains the scheduling policy.
- * @lp contains the scheduling parameters.
* Return 0 if permission is granted.
* @task_getscheduler:
* Check permission before obtaining scheduling information for process
--
2.17.2

2018-10-23 19:42:04

by Kees Cook

Subject: Re: [PATCH] security: fix documentation for the task_setscheduler hook

On Tue, Oct 23, 2018 at 4:12 AM, <[email protected]> wrote:
> From: Denis Efremov <[email protected]>
>
> The task_setscheduler hook was changed in the commit
> "security: remove unused parameter from security_task_setscheduler()"
> (b0ae19811375). The arguments @policy, @lp were removed from the hook.
> This patch updates the documentation accordingly.
>
> Signed-off-by: Denis Efremov <[email protected]>

Reviewed-by: Kees Cook <[email protected]>

-Kees

> ---
> include/linux/lsm_hooks.h | 4 +---
> 1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/include/linux/lsm_hooks.h b/include/linux/lsm_hooks.h
> index accf6f34ac8e..ae3766720264 100644
> --- a/include/linux/lsm_hooks.h
> +++ b/include/linux/lsm_hooks.h
> @@ -655,10 +655,8 @@
> * Return 0 if permission is granted.
> * @task_setscheduler:
> * Check permission before setting scheduling policy and/or parameters of
> - * process @p based on @policy and @lp.
> + * process @p.
> * @p contains the task_struct for process.
> - * @policy contains the scheduling policy.
> - * @lp contains the scheduling parameters.
> * Return 0 if permission is granted.
> * @task_getscheduler:
> * Check permission before obtaining scheduling information for process
> --
> 2.17.2
>



--
Kees Cook