2018-12-03 21:23:26

by Mathieu Malaterre

Subject: [PATCH] mips: annotate implicit fall throughs

There is a plan to build the kernel with -Wimplicit-fallthrough and
these places in the code produced warnings. Fix them up.

Signed-off-by: Mathieu Malaterre <[email protected]>
---
drivers/mtd/nand/raw/jz4780_bch.c | 2 ++
1 file changed, 2 insertions(+)

diff --git a/drivers/mtd/nand/raw/jz4780_bch.c b/drivers/mtd/nand/raw/jz4780_bch.c
index 731c6051d91e..7201827809e9 100644
--- a/drivers/mtd/nand/raw/jz4780_bch.c
+++ b/drivers/mtd/nand/raw/jz4780_bch.c
@@ -136,8 +136,10 @@ static void jz4780_bch_read_parity(struct jz4780_bch *bch, void *buf,
switch (size8) {
case 3:
dest8[2] = (val >> 16) & 0xff;
+ /* fall through */
case 2:
dest8[1] = (val >> 8) & 0xff;
+ /* fall through */
case 1:
dest8[0] = val & 0xff;
break;
--
2.19.2

2018-12-03 21:28:53

by Boris Brezillon

Subject: Re: [PATCH] mips: annotate implicit fall throughs

Hi Mathieu,

The subject prefix should be "mtd: rawnand: jz4780:" not "mips:"

Regards,

Boris

On Mon, 3 Dec 2018 22:22:13 +0100
Mathieu Malaterre <[email protected]> wrote:

> There is a plan to build the kernel with -Wimplicit-fallthrough and
> these places in the code produced warnings. Fix them up.
>
> Signed-off-by: Mathieu Malaterre <[email protected]>
> ---
> drivers/mtd/nand/raw/jz4780_bch.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/drivers/mtd/nand/raw/jz4780_bch.c b/drivers/mtd/nand/raw/jz4780_bch.c
> index 731c6051d91e..7201827809e9 100644
> --- a/drivers/mtd/nand/raw/jz4780_bch.c
> +++ b/drivers/mtd/nand/raw/jz4780_bch.c
> @@ -136,8 +136,10 @@ static void jz4780_bch_read_parity(struct jz4780_bch *bch, void *buf,
> switch (size8) {
> case 3:
> dest8[2] = (val >> 16) & 0xff;
> + /* fall through */
> case 2:
> dest8[1] = (val >> 8) & 0xff;
> + /* fall through */
> case 1:
> dest8[0] = val & 0xff;
> break;

2018-12-04 20:12:08

by Mathieu Malaterre

Subject: [PATCH v2] mtd: rawnand: jz4780: annotate implicit fall throughs

There is a plan to build the kernel with -Wimplicit-fallthrough and
these places in the code produced warnings. Fix them up.

Signed-off-by: Mathieu Malaterre <[email protected]>
---
v2: fix subject prefix non sense

drivers/mtd/nand/raw/jz4780_bch.c | 2 ++
1 file changed, 2 insertions(+)

diff --git a/drivers/mtd/nand/raw/jz4780_bch.c b/drivers/mtd/nand/raw/jz4780_bch.c
index 731c6051d91e..7201827809e9 100644
--- a/drivers/mtd/nand/raw/jz4780_bch.c
+++ b/drivers/mtd/nand/raw/jz4780_bch.c
@@ -136,8 +136,10 @@ static void jz4780_bch_read_parity(struct jz4780_bch *bch, void *buf,
switch (size8) {
case 3:
dest8[2] = (val >> 16) & 0xff;
+ /* fall through */
case 2:
dest8[1] = (val >> 8) & 0xff;
+ /* fall through */
case 1:
dest8[0] = val & 0xff;
break;
--
2.19.2

2018-12-07 18:52:05

by Miquel Raynal

Subject: Re: [PATCH v2] mtd: rawnand: jz4780: annotate implicit fall throughs

Hi Mathieu,

Mathieu Malaterre <[email protected]> wrote on Tue, 4 Dec 2018 21:10:57
+0100:

> There is a plan to build the kernel with -Wimplicit-fallthrough and
> these places in the code produced warnings. Fix them up.
>
> Signed-off-by: Mathieu Malaterre <[email protected]>
> ---
> v2: fix subject prefix non sense
>
> drivers/mtd/nand/raw/jz4780_bch.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/drivers/mtd/nand/raw/jz4780_bch.c b/drivers/mtd/nand/raw/jz4780_bch.c
> index 731c6051d91e..7201827809e9 100644
> --- a/drivers/mtd/nand/raw/jz4780_bch.c
> +++ b/drivers/mtd/nand/raw/jz4780_bch.c
> @@ -136,8 +136,10 @@ static void jz4780_bch_read_parity(struct jz4780_bch *bch, void *buf,
> switch (size8) {
> case 3:
> dest8[2] = (val >> 16) & 0xff;
> + /* fall through */
> case 2:
> dest8[1] = (val >> 8) & 0xff;
> + /* fall through */
> case 1:
> dest8[0] = val & 0xff;
> break;

Applied to nand/next.


Thanks,
Miquèl