2018-11-20 12:35:29

by Krzysztof Kozłowski

[permalink] [raw]
Subject: [BUG BISECT] Missing MTD NAND partitions - mtd: rawnand: Move the ->exec_op() method to nand_controller_ops

Hi all,

Since few days linux-next has problem on Freescale VF500 - MTD seems
to be broken.

Bisect pointed me to commit 7c27338c728e39ef47c83d101959aa332506969d
("mtd: rawnand: Move the ->exec_op() method to nand_controller_ops")
as reason of failure to find MTD partitions.

Toradex Colibri VF50 on Iris board (ARMv7, UP, Cortext-A5, NXP VF500,
128 MB RAM, 128 MB NAND, Systemd: v232) booted from NFS root (NFSv4)
trying to mount UBIFS from NAND/MTD. Board uses VF610 NAND driver.

The MTD partitions are missing entirely (nothing under /dev/mtd).
In the logs you can also see:
[ 1.232161] UBI error: cannot open mtd ubi2, error -2

Attached - dmesg.log

Let me know if you need defconfig or any other information.

Best regards,
Krzysztof


Attachments:
dmesg.log (10.72 kB)

2018-11-20 10:34:54

by Miquel Raynal

[permalink] [raw]
Subject: Re: [BUG BISECT] Missing MTD NAND partitions - mtd: rawnand: Move the ->exec_op() method to nand_controller_ops

Hi Krzysztof,

Krzysztof Kozłowski <[email protected]> wrote on Tue, 20 Nov 2018
10:46:33 +0100:

> Hi all,
>
> Since few days linux-next has problem on Freescale VF500 - MTD seems
> to be broken.
>
> Bisect pointed me to commit 7c27338c728e39ef47c83d101959aa332506969d
> ("mtd: rawnand: Move the ->exec_op() method to nand_controller_ops")
> as reason of failure to find MTD partitions.
>
> Toradex Colibri VF50 on Iris board (ARMv7, UP, Cortext-A5, NXP VF500,
> 128 MB RAM, 128 MB NAND, Systemd: v232) booted from NFS root (NFSv4)
> trying to mount UBIFS from NAND/MTD. Board uses VF610 NAND driver.
>
> The MTD partitions are missing entirely (nothing under /dev/mtd).
> In the logs you can also see:
> [ 1.232161] UBI error: cannot open mtd ubi2, error -2
>
> Attached - dmesg.log
>
> Let me know if you need defconfig or any other information.

Thank you very much for testing and reporting the bug!

Could you please test with this diff applied [1] please? We discussed
with Boris and we think it should fix your setup (and all others also
impacted).

[1] http://code.bulix.org/r1m99i-509201


Thanks,
Miquèl

2018-11-20 12:16:12

by Krzysztof Kozlowski

[permalink] [raw]
Subject: Re: [BUG BISECT] Missing MTD NAND partitions - mtd: rawnand: Move the ->exec_op() method to nand_controller_ops

On Tue, 20 Nov 2018 at 13:09, Boris Brezillon
<[email protected]> wrote:
>
> On Tue, 20 Nov 2018 12:48:46 +0100
> Krzysztof Kozlowski <[email protected]> wrote:
>
> > On Tue, 20 Nov 2018 at 11:33, Miquel Raynal <[email protected]> wrote:
> > >
> > > Hi Krzysztof,
> > >
> > > Krzysztof Kozłowski <[email protected]> wrote on Tue, 20 Nov 2018
> > > 10:46:33 +0100:
> > >
> > > > Hi all,
> > > >
> > > > Since few days linux-next has problem on Freescale VF500 - MTD seems
> > > > to be broken.
> > > >
> > > > Bisect pointed me to commit 7c27338c728e39ef47c83d101959aa332506969d
> > > > ("mtd: rawnand: Move the ->exec_op() method to nand_controller_ops")
> > > > as reason of failure to find MTD partitions.
> > > >
> > > > Toradex Colibri VF50 on Iris board (ARMv7, UP, Cortext-A5, NXP VF500,
> > > > 128 MB RAM, 128 MB NAND, Systemd: v232) booted from NFS root (NFSv4)
> > > > trying to mount UBIFS from NAND/MTD. Board uses VF610 NAND driver.
> > > >
> > > > The MTD partitions are missing entirely (nothing under /dev/mtd).
> > > > In the logs you can also see:
> > > > [ 1.232161] UBI error: cannot open mtd ubi2, error -2
> > > >
> > > > Attached - dmesg.log
> > > >
> > > > Let me know if you need defconfig or any other information.
> > >
> > > Thank you very much for testing and reporting the bug!
> > >
> > > Could you please test with this diff applied [1] please? We discussed
> > > with Boris and we think it should fix your setup (and all others also
> > > impacted).
> > >
> > > [1] http://code.bulix.org/r1m99i-509201
> >
> > error: patch failed: drivers/mtd/nand/raw/nand_base.c:4399
> > error: drivers/mtd/nand/raw/nand_base.c: patch does not apply
> >
> > Maybe you have a git tree with this somewhere?
>
> Yep: https://github.com/bbrezillon/linux/tree/nand/next-fix

Works fine now, thanks!
Tested-by: Krzysztof Kozlowski <[email protected]>

Best regards,
Krzysztof

2018-11-20 14:54:27

by Krzysztof Kozlowski

[permalink] [raw]
Subject: Re: [BUG BISECT] Missing MTD NAND partitions - mtd: rawnand: Move the ->exec_op() method to nand_controller_ops

On Tue, 20 Nov 2018 at 11:33, Miquel Raynal <[email protected]> wrote:
>
> Hi Krzysztof,
>
> Krzysztof Kozłowski <[email protected]> wrote on Tue, 20 Nov 2018
> 10:46:33 +0100:
>
> > Hi all,
> >
> > Since few days linux-next has problem on Freescale VF500 - MTD seems
> > to be broken.
> >
> > Bisect pointed me to commit 7c27338c728e39ef47c83d101959aa332506969d
> > ("mtd: rawnand: Move the ->exec_op() method to nand_controller_ops")
> > as reason of failure to find MTD partitions.
> >
> > Toradex Colibri VF50 on Iris board (ARMv7, UP, Cortext-A5, NXP VF500,
> > 128 MB RAM, 128 MB NAND, Systemd: v232) booted from NFS root (NFSv4)
> > trying to mount UBIFS from NAND/MTD. Board uses VF610 NAND driver.
> >
> > The MTD partitions are missing entirely (nothing under /dev/mtd).
> > In the logs you can also see:
> > [ 1.232161] UBI error: cannot open mtd ubi2, error -2
> >
> > Attached - dmesg.log
> >
> > Let me know if you need defconfig or any other information.
>
> Thank you very much for testing and reporting the bug!
>
> Could you please test with this diff applied [1] please? We discussed
> with Boris and we think it should fix your setup (and all others also
> impacted).
>
> [1] http://code.bulix.org/r1m99i-509201

error: patch failed: drivers/mtd/nand/raw/nand_base.c:4399
error: drivers/mtd/nand/raw/nand_base.c: patch does not apply

Maybe you have a git tree with this somewhere?

Best regards,
Krzysztof

2018-11-20 14:54:38

by Boris Brezillon

[permalink] [raw]
Subject: Re: [BUG BISECT] Missing MTD NAND partitions - mtd: rawnand: Move the ->exec_op() method to nand_controller_ops

On Tue, 20 Nov 2018 12:48:46 +0100
Krzysztof Kozlowski <[email protected]> wrote:

> On Tue, 20 Nov 2018 at 11:33, Miquel Raynal <[email protected]> wrote:
> >
> > Hi Krzysztof,
> >
> > Krzysztof Kozłowski <[email protected]> wrote on Tue, 20 Nov 2018
> > 10:46:33 +0100:
> >
> > > Hi all,
> > >
> > > Since few days linux-next has problem on Freescale VF500 - MTD seems
> > > to be broken.
> > >
> > > Bisect pointed me to commit 7c27338c728e39ef47c83d101959aa332506969d
> > > ("mtd: rawnand: Move the ->exec_op() method to nand_controller_ops")
> > > as reason of failure to find MTD partitions.
> > >
> > > Toradex Colibri VF50 on Iris board (ARMv7, UP, Cortext-A5, NXP VF500,
> > > 128 MB RAM, 128 MB NAND, Systemd: v232) booted from NFS root (NFSv4)
> > > trying to mount UBIFS from NAND/MTD. Board uses VF610 NAND driver.
> > >
> > > The MTD partitions are missing entirely (nothing under /dev/mtd).
> > > In the logs you can also see:
> > > [ 1.232161] UBI error: cannot open mtd ubi2, error -2
> > >
> > > Attached - dmesg.log
> > >
> > > Let me know if you need defconfig or any other information.
> >
> > Thank you very much for testing and reporting the bug!
> >
> > Could you please test with this diff applied [1] please? We discussed
> > with Boris and we think it should fix your setup (and all others also
> > impacted).
> >
> > [1] http://code.bulix.org/r1m99i-509201
>
> error: patch failed: drivers/mtd/nand/raw/nand_base.c:4399
> error: drivers/mtd/nand/raw/nand_base.c: patch does not apply
>
> Maybe you have a git tree with this somewhere?

Yep: https://github.com/bbrezillon/linux/tree/nand/next-fix

2018-12-05 16:12:30

by Krzysztof Kozlowski

[permalink] [raw]
Subject: Re: [BUG BISECT] Missing MTD NAND partitions - mtd: rawnand: Move the ->exec_op() method to nand_controller_ops

On Tue, 20 Nov 2018 at 13:15, Krzysztof Kozlowski <[email protected]> wrote:
>
> On Tue, 20 Nov 2018 at 13:09, Boris Brezillon
> <[email protected]> wrote:
> >
> > On Tue, 20 Nov 2018 12:48:46 +0100
> > Krzysztof Kozlowski <[email protected]> wrote:
> >
> > > On Tue, 20 Nov 2018 at 11:33, Miquel Raynal <[email protected]> wrote:
> > > >
> > > > Hi Krzysztof,
> > > >
> > > > Krzysztof Kozłowski <[email protected]> wrote on Tue, 20 Nov 2018
> > > > 10:46:33 +0100:
> > > >
> > > > > Hi all,
> > > > >
> > > > > Since few days linux-next has problem on Freescale VF500 - MTD seems
> > > > > to be broken.
> > > > >
> > > > > Bisect pointed me to commit 7c27338c728e39ef47c83d101959aa332506969d
> > > > > ("mtd: rawnand: Move the ->exec_op() method to nand_controller_ops")
> > > > > as reason of failure to find MTD partitions.
> > > > >
> > > > > Toradex Colibri VF50 on Iris board (ARMv7, UP, Cortext-A5, NXP VF500,
> > > > > 128 MB RAM, 128 MB NAND, Systemd: v232) booted from NFS root (NFSv4)
> > > > > trying to mount UBIFS from NAND/MTD. Board uses VF610 NAND driver.
> > > > >
> > > > > The MTD partitions are missing entirely (nothing under /dev/mtd).
> > > > > In the logs you can also see:
> > > > > [ 1.232161] UBI error: cannot open mtd ubi2, error -2
> > > > >
> > > > > Attached - dmesg.log
> > > > >
> > > > > Let me know if you need defconfig or any other information.
> > > >
> > > > Thank you very much for testing and reporting the bug!
> > > >
> > > > Could you please test with this diff applied [1] please? We discussed
> > > > with Boris and we think it should fix your setup (and all others also
> > > > impacted).
> > > >
> > > > [1] http://code.bulix.org/r1m99i-509201
> > >
> > > error: patch failed: drivers/mtd/nand/raw/nand_base.c:4399
> > > error: drivers/mtd/nand/raw/nand_base.c: patch does not apply
> > >
> > > Maybe you have a git tree with this somewhere?
> >
> > Yep: https://github.com/bbrezillon/linux/tree/nand/next-fix
>
> Works fine now, thanks!
> Tested-by: Krzysztof Kozlowski <[email protected]>

Although the patch fixed the issue... but it seems it is not in
linux-next. The next is broken since almost two weeks.

Best regards,
Krzysztof

2018-12-05 16:17:45

by Miquel Raynal

[permalink] [raw]
Subject: Re: [BUG BISECT] Missing MTD NAND partitions - mtd: rawnand: Move the ->exec_op() method to nand_controller_ops

Hi Krzysztof,

Krzysztof Kozlowski <[email protected]> wrote on Wed, 5 Dec 2018 17:10:38
+0100:

> On Tue, 20 Nov 2018 at 13:15, Krzysztof Kozlowski <[email protected]> wrote:
> >
> > On Tue, 20 Nov 2018 at 13:09, Boris Brezillon
> > <[email protected]> wrote:
> > >
> > > On Tue, 20 Nov 2018 12:48:46 +0100
> > > Krzysztof Kozlowski <[email protected]> wrote:
> > >
> > > > On Tue, 20 Nov 2018 at 11:33, Miquel Raynal <[email protected]> wrote:
> > > > >
> > > > > Hi Krzysztof,
> > > > >
> > > > > Krzysztof Kozłowski <[email protected]> wrote on Tue, 20 Nov 2018
> > > > > 10:46:33 +0100:
> > > > >
> > > > > > Hi all,
> > > > > >
> > > > > > Since few days linux-next has problem on Freescale VF500 - MTD seems
> > > > > > to be broken.
> > > > > >
> > > > > > Bisect pointed me to commit 7c27338c728e39ef47c83d101959aa332506969d
> > > > > > ("mtd: rawnand: Move the ->exec_op() method to nand_controller_ops")
> > > > > > as reason of failure to find MTD partitions.
> > > > > >
> > > > > > Toradex Colibri VF50 on Iris board (ARMv7, UP, Cortext-A5, NXP VF500,
> > > > > > 128 MB RAM, 128 MB NAND, Systemd: v232) booted from NFS root (NFSv4)
> > > > > > trying to mount UBIFS from NAND/MTD. Board uses VF610 NAND driver.
> > > > > >
> > > > > > The MTD partitions are missing entirely (nothing under /dev/mtd).
> > > > > > In the logs you can also see:
> > > > > > [ 1.232161] UBI error: cannot open mtd ubi2, error -2
> > > > > >
> > > > > > Attached - dmesg.log
> > > > > >
> > > > > > Let me know if you need defconfig or any other information.
> > > > >
> > > > > Thank you very much for testing and reporting the bug!
> > > > >
> > > > > Could you please test with this diff applied [1] please? We discussed
> > > > > with Boris and we think it should fix your setup (and all others also
> > > > > impacted).
> > > > >
> > > > > [1] http://code.bulix.org/r1m99i-509201
> > > >
> > > > error: patch failed: drivers/mtd/nand/raw/nand_base.c:4399
> > > > error: drivers/mtd/nand/raw/nand_base.c: patch does not apply
> > > >
> > > > Maybe you have a git tree with this somewhere?
> > >
> > > Yep: https://github.com/bbrezillon/linux/tree/nand/next-fix
> >
> > Works fine now, thanks!
> > Tested-by: Krzysztof Kozlowski <[email protected]>
>
> Although the patch fixed the issue... but it seems it is not in
> linux-next. The next is broken since almost two weeks.
>

Sorry, this is definitely in my TODO list, I need to put the NAND
branch in shape this week anyway.

Thanks,
Miquèl

2018-12-06 20:16:14

by Miquel Raynal

[permalink] [raw]
Subject: Re: [BUG BISECT] Missing MTD NAND partitions - mtd: rawnand: Move the ->exec_op() method to nand_controller_ops

Hi Krzysztof,

Krzysztof Kozlowski <[email protected]> wrote on Wed, 5 Dec 2018 17:10:38
+0100:

> On Tue, 20 Nov 2018 at 13:15, Krzysztof Kozlowski <[email protected]> wrote:
> >
> > On Tue, 20 Nov 2018 at 13:09, Boris Brezillon
> > <[email protected]> wrote:
> > >
> > > On Tue, 20 Nov 2018 12:48:46 +0100
> > > Krzysztof Kozlowski <[email protected]> wrote:
> > >
> > > > On Tue, 20 Nov 2018 at 11:33, Miquel Raynal <[email protected]> wrote:
> > > > >
> > > > > Hi Krzysztof,
> > > > >
> > > > > Krzysztof Kozłowski <[email protected]> wrote on Tue, 20 Nov 2018
> > > > > 10:46:33 +0100:
> > > > >
> > > > > > Hi all,
> > > > > >
> > > > > > Since few days linux-next has problem on Freescale VF500 - MTD seems
> > > > > > to be broken.
> > > > > >
> > > > > > Bisect pointed me to commit 7c27338c728e39ef47c83d101959aa332506969d
> > > > > > ("mtd: rawnand: Move the ->exec_op() method to nand_controller_ops")
> > > > > > as reason of failure to find MTD partitions.
> > > > > >
> > > > > > Toradex Colibri VF50 on Iris board (ARMv7, UP, Cortext-A5, NXP VF500,
> > > > > > 128 MB RAM, 128 MB NAND, Systemd: v232) booted from NFS root (NFSv4)
> > > > > > trying to mount UBIFS from NAND/MTD. Board uses VF610 NAND driver.
> > > > > >
> > > > > > The MTD partitions are missing entirely (nothing under /dev/mtd).
> > > > > > In the logs you can also see:
> > > > > > [ 1.232161] UBI error: cannot open mtd ubi2, error -2
> > > > > >
> > > > > > Attached - dmesg.log
> > > > > >
> > > > > > Let me know if you need defconfig or any other information.
> > > > >
> > > > > Thank you very much for testing and reporting the bug!
> > > > >
> > > > > Could you please test with this diff applied [1] please? We discussed
> > > > > with Boris and we think it should fix your setup (and all others also
> > > > > impacted).
> > > > >
> > > > > [1] http://code.bulix.org/r1m99i-509201
> > > >
> > > > error: patch failed: drivers/mtd/nand/raw/nand_base.c:4399
> > > > error: drivers/mtd/nand/raw/nand_base.c: patch does not apply
> > > >
> > > > Maybe you have a git tree with this somewhere?
> > >
> > > Yep: https://github.com/bbrezillon/linux/tree/nand/next-fix
> >
> > Works fine now, thanks!
> > Tested-by: Krzysztof Kozlowski <[email protected]>
>
> Although the patch fixed the issue... but it seems it is not in
> linux-next. The next is broken since almost two weeks.
>
> Best regards,
> Krzysztof

Sorry for the huge delay, fixup applied.


Thanks,
Miquèl