2018-12-18 07:04:06

by Wei Yongjun

Subject: [PATCH -next] regulator: act8945a-regulator: make symbol act8945a_pm static

Fixes the following sparse warning:

drivers/regulator/act8945a-regulator.c:340:1: warning:
symbol 'act8945a_pm' was not declared. Should it be static?

Fixes: 7482d6ecc68e ("regulator: act8945a-regulator: Implement PM functionalities")
Signed-off-by: Wei Yongjun <[email protected]>
---
drivers/regulator/act8945a-regulator.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/regulator/act8945a-regulator.c b/drivers/regulator/act8945a-regulator.c
index 90572b6..dc3942b 100644
--- a/drivers/regulator/act8945a-regulator.c
+++ b/drivers/regulator/act8945a-regulator.c
@@ -337,7 +337,7 @@ static int act8945a_suspend(struct device *pdev)
return regmap_write(act8945a->regmap, ACT8945A_SYS_CTRL, 0x42);
}

-SIMPLE_DEV_PM_OPS(act8945a_pm, act8945a_suspend, NULL);
+static SIMPLE_DEV_PM_OPS(act8945a_pm, act8945a_suspend, NULL);

static void act8945a_pmic_shutdown(struct platform_device *pdev)
{

2018-12-20 18:51:53

by Boris Brezillon

Subject: Re: [PATCH -next] regulator: act8945a-regulator: make symbol act8945a_pm static

On Tue, 18 Dec 2018 07:10:21 +0000
Wei Yongjun <[email protected]> wrote:

> Fixes the following sparse warning:
>
> drivers/regulator/act8945a-regulator.c:340:1: warning:
> symbol 'act8945a_pm' was not declared. Should it be static?
>
> Fixes: 7482d6ecc68e ("regulator: act8945a-regulator: Implement PM functionalities")
> Signed-off-by: Wei Yongjun <[email protected]>

Reviewed-by: Boris Brezillon <[email protected]>

> ---
> drivers/regulator/act8945a-regulator.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/regulator/act8945a-regulator.c b/drivers/regulator/act8945a-regulator.c
> index 90572b6..dc3942b 100644
> --- a/drivers/regulator/act8945a-regulator.c
> +++ b/drivers/regulator/act8945a-regulator.c
> @@ -337,7 +337,7 @@ static int act8945a_suspend(struct device *pdev)
> return regmap_write(act8945a->regmap, ACT8945A_SYS_CTRL, 0x42);
> }
>
> -SIMPLE_DEV_PM_OPS(act8945a_pm, act8945a_suspend, NULL);
> +static SIMPLE_DEV_PM_OPS(act8945a_pm, act8945a_suspend, NULL);
>
> static void act8945a_pmic_shutdown(struct platform_device *pdev)
> {
>
>
>