This patch series extends OPAL support: it adds IOCTL for setting the shadow
MBR done flag which can be useful for unlocking an OPAL disk on boot and it adds
IOCTL for writing to the shadow MBR. Also included are some minor fixes and
improvements.
This series is based on the original work done by Jonas Rabenstein which was
submitted in March 2018.[1] I tried to apply suggestions made in review on the
list and do some further improvements.
The most contentions issue in the original series was the IOCTL for shadow MBR
write but I think no better approach was found[2] so this was not changed. I'm
open to suggestions.
There is a fork of sed-opal-temp that can use these new IOCTLs.[3] I tested
these on Samsung 840 EVO and 850 EVO drives, on x86-64 and arm64 systems.
The series applies on v5.0-rc2.
[1] https://lore.kernel.org/lkml/[email protected]/
[2] https://lore.kernel.org/lkml/20180405203443.ye4gnw5aey2exlkn@sbauer-Z170X-UD5/
[3] https://github.com/ghostav/sed-opal-temp
David Kozub (8):
block: sed-opal: fix typos and formatting
block: sed-opal: close parameter list in cmd_finalize
block: sed-opal: unify cmd start
block: sed-opal: unify error handling of responses
block: sed-opal: reuse response_get_token to decrease code duplication
block: sed-opal: pass steps via argument rather than via opal_dev
block: sed-opal: don't repeat opal_discovery0 in each steps array
block: sed-opal: rename next to execute_steps
Jonas Rabenstein (8):
block: sed-opal: use correct macro for method length
block: sed-opal: unify space check in add_token_*
block: sed-opal: print failed function address
block: sed-opal: split generation of bytestring header and content
block: sed-opal: add ioctl for done-mark of shadow mbr
block: sed-opal: ioctl for writing to shadow mbr
block: sed-opal: unify retrieval of table columns
block: sed-opal: check size of shadow mbr
block/opal_proto.h | 18 +
block/sed-opal.c | 843 +++++++++++++++++-----------------
include/linux/sed-opal.h | 2 +
include/uapi/linux/sed-opal.h | 9 +
4 files changed, 449 insertions(+), 423 deletions(-)
--
2.20.1
Hi David,
the way the series appear looks odd, because it wasn't threaded or
even ordered, and the patches from Jonas seem to have been sent out
by you under his name. Can you resend them carefully threaded, all
mails from you with the additional from header for resends?
git-send-email will do it all for you, but it can also be done manually.
On Thu, 17 Jan 2019, Christoph Hellwig wrote:
> the way the series appear looks odd, because it wasn't threaded or
> even ordered, and the patches from Jonas seem to have been sent out
> by you under his name. Can you resend them carefully threaded, all
> mails from you with the additional from header for resends?
Ouch. I'm sorry about the ordering/threading. I (wrongly) assumed that if
I just send the mails in order, that suffices. I'll try to fix that in v2.
W.r.t. "from": Most of the patches were originally created by Jonas. I
touched some in order to apply review suggestions or make some small
fixes. But some stayed identical to Jonas' version and I didn't want to
strip him of authorship. I used git format-patch to produce the mails and
the commit author was propagated to the from header.
What is the proper way when I am not the author?
Best regards,
David
On Thu, Jan 17, 2019 at 10:40:49AM +0100, David Kozub wrote:
> On Thu, 17 Jan 2019, Christoph Hellwig wrote:
>
> > the way the series appear looks odd, because it wasn't threaded or
> > even ordered, and the patches from Jonas seem to have been sent out
> > by you under his name. Can you resend them carefully threaded, all
> > mails from you with the additional from header for resends?
>
> Ouch. I'm sorry about the ordering/threading. I (wrongly) assumed that if I
> just send the mails in order, that suffices. I'll try to fix that in v2.
>
> W.r.t. "from": Most of the patches were originally created by Jonas. I
> touched some in order to apply review suggestions or make some small fixes.
> But some stayed identical to Jonas' version and I didn't want to strip him
> of authorship. I used git format-patch to produce the mails and the commit
> author was propagated to the from header.
>
> What is the proper way when I am not the author?
Send the actual mail as from you, and put another From: line for
the original author into the mail body as the first non-empty line.
On Wed, Jan 16, 2019 at 09:56:51PM +0000, David Kozub wrote:
> block: sed-opal: rename next to execute_steps
I don't see this change anywhere on the lists. I have 0->15, but am missing 16/16.
Please resend v2 with the changes Christoph requested, so it's easier to review.
Lastly, please CC me on the changes, and I will review them:
[email protected]
I don't work at Intel anymore -- maintainers never got updated.
> Jonas Rabenstein (8):
> block: sed-opal: use correct macro for method length
> block: sed-opal: unify space check in add_token_*
> block: sed-opal: print failed function address
> block: sed-opal: split generation of bytestring header and content
> block: sed-opal: add ioctl for done-mark of shadow mbr
> block: sed-opal: ioctl for writing to shadow mbr
> block: sed-opal: unify retrieval of table columns
> block: sed-opal: check size of shadow mbr
>
> block/opal_proto.h | 18 +
> block/sed-opal.c | 843 +++++++++++++++++-----------------
> include/linux/sed-opal.h | 2 +
> include/uapi/linux/sed-opal.h | 9 +
> 4 files changed, 449 insertions(+), 423 deletions(-)
>
> --
> 2.20.1