2019-02-04 19:09:45

by Ray Jui

Subject: [PATCH] phy: bcm-sr-pcie: Change operation when PIPEMUX=1

From: Qingmin Liu <[email protected]>

When PIPEMIX=1, change the operation from 2x8 EP to 1x8 EP + 1x8 RC.

Signed-off-by: Qingmin Liu <[email protected]>
Signed-off-by: Ray Jui <[email protected]>
---
drivers/phy/broadcom/phy-bcm-sr-pcie.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/phy/broadcom/phy-bcm-sr-pcie.c b/drivers/phy/broadcom/phy-bcm-sr-pcie.c
index c10e95f86de5..96a3af126a78 100644
--- a/drivers/phy/broadcom/phy-bcm-sr-pcie.c
+++ b/drivers/phy/broadcom/phy-bcm-sr-pcie.c
@@ -78,8 +78,8 @@ struct sr_pcie_phy_core {
static const u8 pipemux_table[] = {
/* PIPEMUX = 0, EP 1x16 */
0x00,
- /* PIPEMUX = 1, EP 2x8 */
- 0x00,
+ /* PIPEMUX = 1, EP 1x8 + RC 1x8, core 7 */
+ 0x80,
/* PIPEMUX = 2, EP 4x4 */
0x00,
/* PIPEMUX = 3, RC 2x8, cores 0, 7 */
--
2.17.1

2019-02-04 19:24:00

by Scott Branden

Subject: Re: [PATCH] phy: bcm-sr-pcie: Change operation when PIPEMUX=1

Looks good.

On 2019-02-04 11:07 a.m., Ray Jui wrote:
> From: Qingmin Liu <[email protected]>
>
> When PIPEMIX=1, change the operation from 2x8 EP to 1x8 EP + 1x8 RC.
>
> Signed-off-by: Qingmin Liu <[email protected]>
> Signed-off-by: Ray Jui <[email protected]>
Acked-by: Scott Branden <[email protected]>
> ---
> drivers/phy/broadcom/phy-bcm-sr-pcie.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/phy/broadcom/phy-bcm-sr-pcie.c b/drivers/phy/broadcom/phy-bcm-sr-pcie.c
> index c10e95f86de5..96a3af126a78 100644
> --- a/drivers/phy/broadcom/phy-bcm-sr-pcie.c
> +++ b/drivers/phy/broadcom/phy-bcm-sr-pcie.c
> @@ -78,8 +78,8 @@ struct sr_pcie_phy_core {
> static const u8 pipemux_table[] = {
> /* PIPEMUX = 0, EP 1x16 */
> 0x00,
> - /* PIPEMUX = 1, EP 2x8 */
> - 0x00,
> + /* PIPEMUX = 1, EP 1x8 + RC 1x8, core 7 */
> + 0x80,
> /* PIPEMUX = 2, EP 4x4 */
> 0x00,
> /* PIPEMUX = 3, RC 2x8, cores 0, 7 */

2019-02-06 12:17:16

by Kishon Vijay Abraham I

Subject: Re: [PATCH] phy: bcm-sr-pcie: Change operation when PIPEMUX=1

On 05/02/19 12:51 AM, Scott Branden wrote:
> Looks good.
>
> On 2019-02-04 11:07 a.m., Ray Jui wrote:
>> From: Qingmin Liu <[email protected]>
>>
>> When PIPEMIX=1, change the operation from 2x8 EP to 1x8 EP + 1x8 RC.
>>
>> Signed-off-by: Qingmin Liu <[email protected]>
>> Signed-off-by: Ray Jui <[email protected]>
> Acked-by: Scott Branden <[email protected]>

merged, thanks.

-Kishon
>> ---
>>   drivers/phy/broadcom/phy-bcm-sr-pcie.c | 4 ++--
>>   1 file changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/drivers/phy/broadcom/phy-bcm-sr-pcie.c
>> b/drivers/phy/broadcom/phy-bcm-sr-pcie.c
>> index c10e95f86de5..96a3af126a78 100644
>> --- a/drivers/phy/broadcom/phy-bcm-sr-pcie.c
>> +++ b/drivers/phy/broadcom/phy-bcm-sr-pcie.c
>> @@ -78,8 +78,8 @@ struct sr_pcie_phy_core {
>>   static const u8 pipemux_table[] = {
>>       /* PIPEMUX = 0, EP 1x16 */
>>       0x00,
>> -    /* PIPEMUX = 1, EP 2x8 */
>> -    0x00,
>> +    /* PIPEMUX = 1, EP 1x8 + RC 1x8, core 7 */
>> +    0x80,
>>       /* PIPEMUX = 2, EP 4x4 */
>>       0x00,
>>       /* PIPEMUX = 3, RC 2x8, cores 0, 7 */