LinuxLists.cc - [PATCH -next] ASoC: cs35l36: Make some symbols static

2019-02-18 08:02:21

Subject: [PATCH -next] ASoC: cs35l36: Make some symbols static

Fixes the following sparse warnings:

sound/soc/codecs/cs35l36.c:135:20: warning:
symbol 'cs35l36_reg' was not declared. Should it be static?
sound/soc/codecs/cs35l36.c:248:6: warning:
symbol 'cs35l36_readable_reg' was not declared. Should it be static?
sound/soc/codecs/cs35l36.c:398:6: warning:
symbol 'cs35l36_precious_reg' was not declared. Should it be static?
sound/soc/codecs/cs35l36.c:410:6: warning:
symbol 'cs35l36_volatile_reg' was not declared. Should it be static?

Fixes: 6ba9dd6c893b ("ASoC: cs35l36: Add support for Cirrus CS35L36 Amplifier")
Signed-off-by: Wei Yongjun <[email protected]>
---
sound/soc/codecs/cs35l36.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/sound/soc/codecs/cs35l36.c b/sound/soc/codecs/cs35l36.c
index 4f880a678812..005f1adc80b8 100644
--- a/sound/soc/codecs/cs35l36.c
+++ b/sound/soc/codecs/cs35l36.c
@@ -132,7 +132,7 @@ static const struct cs35l36_pll_config cs35l36_pll_sysclk[] = {
{27000000, 0x3F, 0x0A},
};

-struct reg_default cs35l36_reg[] = {
+static struct reg_default cs35l36_reg[] = {
{CS35L36_TESTKEY_CTRL, 0x00000000},
{CS35L36_USERKEY_CTL, 0x00000000},
{CS35L36_OTP_CTRL1, 0x00002460},
@@ -245,7 +245,7 @@ struct reg_default cs35l36_reg[] = {
{CS35L36_PAC_INT7_CTRL, 0x00000001},
};

-bool cs35l36_readable_reg(struct device *dev, unsigned int reg)
+static bool cs35l36_readable_reg(struct device *dev, unsigned int reg)
{
switch (reg) {
case CS35L36_SW_RESET:
@@ -395,7 +395,7 @@ bool cs35l36_readable_reg(struct device *dev, unsigned int reg)
}
}

-bool cs35l36_precious_reg(struct device *dev, unsigned int reg)
+static bool cs35l36_precious_reg(struct device *dev, unsigned int reg)
{
switch (reg) {
case CS35L36_TESTKEY_CTRL:
@@ -407,7 +407,7 @@ bool cs35l36_precious_reg(struct device *dev, unsigned int reg)
}
}

-bool cs35l36_volatile_reg(struct device *dev, unsigned int reg)
+static bool cs35l36_volatile_reg(struct device *dev, unsigned int reg)
{
switch (reg) {
case CS35L36_SW_RESET:

2019-02-18 19:02:01

by Schulman, James

[permalink] [raw]

Subject: Re: [PATCH -next] ASoC: cs35l36: Make some symbols static

On Mon, 18 Feb 2019, Wei Yongjun wrote:

> Fixes the following sparse warnings:
>
> sound/soc/codecs/cs35l36.c:135:20: warning:
> symbol 'cs35l36_reg' was not declared. Should it be static?
> sound/soc/codecs/cs35l36.c:248:6: warning:
> symbol 'cs35l36_readable_reg' was not declared. Should it be static?
> sound/soc/codecs/cs35l36.c:398:6: warning:
> symbol 'cs35l36_precious_reg' was not declared. Should it be static?
> sound/soc/codecs/cs35l36.c:410:6: warning:
> symbol 'cs35l36_volatile_reg' was not declared. Should it be static?
>
> Fixes: 6ba9dd6c893b ("ASoC: cs35l36: Add support for Cirrus CS35L36 Amplifier")
> Signed-off-by: Wei Yongjun <[email protected]>
> ---
> sound/soc/codecs/cs35l36.c | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/sound/soc/codecs/cs35l36.c b/sound/soc/codecs/cs35l36.c
> index 4f880a678812..005f1adc80b8 100644
> --- a/sound/soc/codecs/cs35l36.c
> +++ b/sound/soc/codecs/cs35l36.c
> @@ -132,7 +132,7 @@ static const struct cs35l36_pll_config cs35l36_pll_sysclk[] = {
> {27000000, 0x3F, 0x0A},
> };
>
> -struct reg_default cs35l36_reg[] = {
> +static struct reg_default cs35l36_reg[] = {
> {CS35L36_TESTKEY_CTRL, 0x00000000},
> {CS35L36_USERKEY_CTL, 0x00000000},
> {CS35L36_OTP_CTRL1, 0x00002460},
> @@ -245,7 +245,7 @@ struct reg_default cs35l36_reg[] = {
> {CS35L36_PAC_INT7_CTRL, 0x00000001},
> };
>
> -bool cs35l36_readable_reg(struct device *dev, unsigned int reg)
> +static bool cs35l36_readable_reg(struct device *dev, unsigned int reg)
> {
> switch (reg) {
> case CS35L36_SW_RESET:
> @@ -395,7 +395,7 @@ bool cs35l36_readable_reg(struct device *dev, unsigned int reg)
> }
> }
>
> -bool cs35l36_precious_reg(struct device *dev, unsigned int reg)
> +static bool cs35l36_precious_reg(struct device *dev, unsigned int reg)
> {
> switch (reg) {
> case CS35L36_TESTKEY_CTRL:
> @@ -407,7 +407,7 @@ bool cs35l36_precious_reg(struct device *dev, unsigned int reg)
> }
> }
>
> -bool cs35l36_volatile_reg(struct device *dev, unsigned int reg)
> +static bool cs35l36_volatile_reg(struct device *dev, unsigned int reg)
> {
> switch (reg) {
> case CS35L36_SW_RESET:
>
>
>
>

Thanks Wei. I agree with the changes.

Acked-by: James Schulman <[email protected]>

2019-02-18 19:24:11

by Mark Brown

[permalink] [raw]

Subject: Applied "ASoC: cs35l36: Make some symbols static" to the asoc tree

The patch

ASoC: cs35l36: Make some symbols static

has been applied to the asoc tree at

https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git

All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent to Linus during
the next merge window (or sooner if it is a bug fix), however if
problems are discovered then the patch may be dropped or reverted.

You may get further e-mails resulting from automated or manual testing
and review of the tree, please engage with people reporting problems and
send followup patches addressing any issues that are reported if needed.

If any updates are required or you are submitting further changes they
should be sent as incremental updates against current git, existing
patches will not be replaced.

Please add any relevant lists and maintainers to the CCs when replying
to this mail.

Thanks,
Mark

From b2c02c63ac254530cffe3a7dc7d4e433da1b3a67 Mon Sep 17 00:00:00 2001
From: Wei Yongjun <[email protected]>
Date: Mon, 18 Feb 2019 07:46:53 +0000
Subject: [PATCH] ASoC: cs35l36: Make some symbols static

Fixes the following sparse warnings:

sound/soc/codecs/cs35l36.c:135:20: warning:
symbol 'cs35l36_reg' was not declared. Should it be static?
sound/soc/codecs/cs35l36.c:248:6: warning:
symbol 'cs35l36_readable_reg' was not declared. Should it be static?
sound/soc/codecs/cs35l36.c:398:6: warning:
symbol 'cs35l36_precious_reg' was not declared. Should it be static?
sound/soc/codecs/cs35l36.c:410:6: warning:
symbol 'cs35l36_volatile_reg' was not declared. Should it be static?

Fixes: 6ba9dd6c893b ("ASoC: cs35l36: Add support for Cirrus CS35L36 Amplifier")
Signed-off-by: Wei Yongjun <[email protected]>
Acked-by: James Schulman <[email protected]>
Signed-off-by: Mark Brown <[email protected]>
---
sound/soc/codecs/cs35l36.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/sound/soc/codecs/cs35l36.c b/sound/soc/codecs/cs35l36.c
index e374fffb7e17..dc8cf61b9db8 100644
--- a/sound/soc/codecs/cs35l36.c
+++ b/sound/soc/codecs/cs35l36.c
@@ -131,7 +131,7 @@ static const struct cs35l36_pll_config cs35l36_pll_sysclk[] = {
{27000000, 0x3F, 0x0A},
};

-struct reg_default cs35l36_reg[] = {
+static struct reg_default cs35l36_reg[] = {
{CS35L36_TESTKEY_CTRL, 0x00000000},
{CS35L36_USERKEY_CTL, 0x00000000},
{CS35L36_OTP_CTRL1, 0x00002460},
@@ -244,7 +244,7 @@ struct reg_default cs35l36_reg[] = {
{CS35L36_PAC_INT7_CTRL, 0x00000001},
};

-bool cs35l36_readable_reg(struct device *dev, unsigned int reg)
+static bool cs35l36_readable_reg(struct device *dev, unsigned int reg)
{
switch (reg) {
case CS35L36_SW_RESET:
@@ -394,7 +394,7 @@ bool cs35l36_readable_reg(struct device *dev, unsigned int reg)
}
}

-bool cs35l36_precious_reg(struct device *dev, unsigned int reg)
+static bool cs35l36_precious_reg(struct device *dev, unsigned int reg)
{
switch (reg) {
case CS35L36_TESTKEY_CTRL:
@@ -406,7 +406,7 @@ bool cs35l36_precious_reg(struct device *dev, unsigned int reg)
}
}

-bool cs35l36_volatile_reg(struct device *dev, unsigned int reg)
+static bool cs35l36_volatile_reg(struct device *dev, unsigned int reg)
{
switch (reg) {
case CS35L36_SW_RESET:
--
2.20.1

2019-02-18 19:30:08

by Mark Brown

[permalink] [raw]