2019-02-20 14:36:21

by Anson Huang

Subject: [PATCH V3 1/2] dt-bindings: imx: remove unused resources from scu resource table

Removes below resources which were defined during
pre-silicon phase and the real silicons do NOT have
them, they have never been used, latest system
controller firmware also removed them:

IMX_SC_R_DC_0_CAPTURE0
IMX_SC_R_DC_0_CAPTURE1
IMX_SC_R_DC_0_INTEGRAL0
IMX_SC_R_DC_0_INTEGRAL1
IMX_SC_R_DC_0_FRAC1
IMX_SC_R_DC_1_CAPTURE0
IMX_SC_R_DC_1_CAPTURE1
IMX_SC_R_DC_1_INTEGRAL0
IMX_SC_R_DC_1_INTEGRAL1
IMX_SC_R_DC_1_FRAC1
IMX_SC_R_GPU_3_PID0
IMX_SC_R_M4_0_SIM
IMX_SC_R_M4_0_WDOG
IMX_SC_R_M4_1_SIM
IMX_SC_R_M4_1_WDOG

Signed-off-by: Anson Huang <[email protected]>
---
No changes since V2, just separate the patch to 2, 1 patch to remove resources and the other is to add new
resources.
---
include/dt-bindings/firmware/imx/rsrc.h | 30 +++++++++++++++---------------
1 file changed, 15 insertions(+), 15 deletions(-)

diff --git a/include/dt-bindings/firmware/imx/rsrc.h b/include/dt-bindings/firmware/imx/rsrc.h
index 4481f2d..32cce37 100644
--- a/include/dt-bindings/firmware/imx/rsrc.h
+++ b/include/dt-bindings/firmware/imx/rsrc.h
@@ -36,15 +36,15 @@
#define IMX_SC_R_DC_0_BLIT1 20
#define IMX_SC_R_DC_0_BLIT2 21
#define IMX_SC_R_DC_0_BLIT_OUT 22
-#define IMX_SC_R_DC_0_CAPTURE0 23
-#define IMX_SC_R_DC_0_CAPTURE1 24
+#define IMX_SC_R_UNUSED19 23
+#define IMX_SC_R_UNUSED5 24
#define IMX_SC_R_DC_0_WARP 25
-#define IMX_SC_R_DC_0_INTEGRAL0 26
-#define IMX_SC_R_DC_0_INTEGRAL1 27
+#define IMX_SC_R_UNUSED7 26
+#define IMX_SC_R_UNUSED8 27
#define IMX_SC_R_DC_0_VIDEO0 28
#define IMX_SC_R_DC_0_VIDEO1 29
#define IMX_SC_R_DC_0_FRAC0 30
-#define IMX_SC_R_DC_0_FRAC1 31
+#define IMX_SC_R_UNUSED20 31
#define IMX_SC_R_DC_0 32
#define IMX_SC_R_GPU_2_PID0 33
#define IMX_SC_R_DC_0_PLL_0 34
@@ -53,17 +53,17 @@
#define IMX_SC_R_DC_1_BLIT1 37
#define IMX_SC_R_DC_1_BLIT2 38
#define IMX_SC_R_DC_1_BLIT_OUT 39
-#define IMX_SC_R_DC_1_CAPTURE0 40
-#define IMX_SC_R_DC_1_CAPTURE1 41
+#define IMX_SC_R_UNUSED9 40
+#define IMX_SC_R_UNUSED10 41
#define IMX_SC_R_DC_1_WARP 42
-#define IMX_SC_R_DC_1_INTEGRAL0 43
-#define IMX_SC_R_DC_1_INTEGRAL1 44
+#define IMX_SC_R_UNUSED11 43
+#define IMX_SC_R_UNUSED12 44
#define IMX_SC_R_DC_1_VIDEO0 45
#define IMX_SC_R_DC_1_VIDEO1 46
#define IMX_SC_R_DC_1_FRAC0 47
-#define IMX_SC_R_DC_1_FRAC1 48
+#define IMX_SC_R_UNUSED13 48
#define IMX_SC_R_DC_1 49
-#define IMX_SC_R_GPU_3_PID0 50
+#define IMX_SC_R_UNUSED14 50
#define IMX_SC_R_DC_1_PLL_0 51
#define IMX_SC_R_DC_1_PLL_1 52
#define IMX_SC_R_SPI_0 53
@@ -303,8 +303,8 @@
#define IMX_SC_R_M4_0_UART 287
#define IMX_SC_R_M4_0_I2C 288
#define IMX_SC_R_M4_0_INTMUX 289
-#define IMX_SC_R_M4_0_SIM 290
-#define IMX_SC_R_M4_0_WDOG 291
+#define IMX_SC_R_UNUSED15 290
+#define IMX_SC_R_UNUSED16 291
#define IMX_SC_R_M4_0_MU_0B 292
#define IMX_SC_R_M4_0_MU_0A0 293
#define IMX_SC_R_M4_0_MU_0A1 294
@@ -323,8 +323,8 @@
#define IMX_SC_R_M4_1_UART 307
#define IMX_SC_R_M4_1_I2C 308
#define IMX_SC_R_M4_1_INTMUX 309
-#define IMX_SC_R_M4_1_SIM 310
-#define IMX_SC_R_M4_1_WDOG 311
+#define IMX_SC_R_UNUSED17 310
+#define IMX_SC_R_UNUSED18 311
#define IMX_SC_R_M4_1_MU_0B 312
#define IMX_SC_R_M4_1_MU_0A0 313
#define IMX_SC_R_M4_1_MU_0A1 314
--
2.7.4

2019-02-20 14:36:27

by Anson Huang

Subject: [PATCH V3 2/2] dt-bindings: imx: add new resources to scu resource table

Add new resources as below according to latest system
controller firmware for new features:

IMX_SC_R_PERF
IMX_SC_R_OCRAM
IMX_SC_R_DMA_5_CH0
IMX_SC_R_DMA_5_CH1
IMX_SC_R_DMA_5_CH2
IMX_SC_R_DMA_5_CH3
IMX_SC_R_ATTESTATION

Signed-off-by: Anson Huang <[email protected]>
---
No changes since V2, just separate the patch to 2, 1 patch to remove resources and the other is to add new
resources.
---
include/dt-bindings/firmware/imx/rsrc.h | 11 ++++++++---
1 file changed, 8 insertions(+), 3 deletions(-)

diff --git a/include/dt-bindings/firmware/imx/rsrc.h b/include/dt-bindings/firmware/imx/rsrc.h
index 32cce37..ba2572b 100644
--- a/include/dt-bindings/firmware/imx/rsrc.h
+++ b/include/dt-bindings/firmware/imx/rsrc.h
@@ -36,7 +36,7 @@
#define IMX_SC_R_DC_0_BLIT1 20
#define IMX_SC_R_DC_0_BLIT2 21
#define IMX_SC_R_DC_0_BLIT_OUT 22
-#define IMX_SC_R_UNUSED19 23
+#define IMX_SC_R_PERF 23
#define IMX_SC_R_UNUSED5 24
#define IMX_SC_R_DC_0_WARP 25
#define IMX_SC_R_UNUSED7 26
@@ -337,7 +337,7 @@
#define IMX_SC_R_IRQSTR_SCU2 321
#define IMX_SC_R_IRQSTR_DSP 322
#define IMX_SC_R_ELCDIF_PLL 323
-#define IMX_SC_R_UNUSED6 324
+#define IMX_SC_R_OCRAM 324
#define IMX_SC_R_AUDIO_PLL_0 325
#define IMX_SC_R_PI_0 326
#define IMX_SC_R_PI_0_PWM_0 327
@@ -554,6 +554,11 @@
#define IMX_SC_R_VPU_MU_3 538
#define IMX_SC_R_VPU_ENC_1 539
#define IMX_SC_R_VPU 540
-#define IMX_SC_R_LAST 541
+#define IMX_SC_R_DMA_5_CH0 541
+#define IMX_SC_R_DMA_5_CH1 542
+#define IMX_SC_R_DMA_5_CH2 543
+#define IMX_SC_R_DMA_5_CH3 544
+#define IMX_SC_R_ATTESTATION 545
+#define IMX_SC_R_LAST 546

#endif /* __DT_BINDINGS_RSCRC_IMX_H */
--
2.7.4

2019-02-22 19:47:33

by Rob Herring (Arm)

Subject: Re: [PATCH V3 1/2] dt-bindings: imx: remove unused resources from scu resource table

On Wed, Feb 20, 2019 at 02:35:02PM +0000, Anson Huang wrote:
> Removes below resources which were defined during
> pre-silicon phase and the real silicons do NOT have
> them, they have never been used, latest system
> controller firmware also removed them:
>
> IMX_SC_R_DC_0_CAPTURE0
> IMX_SC_R_DC_0_CAPTURE1
> IMX_SC_R_DC_0_INTEGRAL0
> IMX_SC_R_DC_0_INTEGRAL1
> IMX_SC_R_DC_0_FRAC1
> IMX_SC_R_DC_1_CAPTURE0
> IMX_SC_R_DC_1_CAPTURE1
> IMX_SC_R_DC_1_INTEGRAL0
> IMX_SC_R_DC_1_INTEGRAL1
> IMX_SC_R_DC_1_FRAC1
> IMX_SC_R_GPU_3_PID0
> IMX_SC_R_M4_0_SIM
> IMX_SC_R_M4_0_WDOG
> IMX_SC_R_M4_1_SIM
> IMX_SC_R_M4_1_WDOG
>
> Signed-off-by: Anson Huang <[email protected]>
> ---
> No changes since V2, just separate the patch to 2, 1 patch to remove resources and the other is to add new
> resources.
> ---
> include/dt-bindings/firmware/imx/rsrc.h | 30 +++++++++++++++---------------
> 1 file changed, 15 insertions(+), 15 deletions(-)
>
> diff --git a/include/dt-bindings/firmware/imx/rsrc.h b/include/dt-bindings/firmware/imx/rsrc.h
> index 4481f2d..32cce37 100644
> --- a/include/dt-bindings/firmware/imx/rsrc.h
> +++ b/include/dt-bindings/firmware/imx/rsrc.h
> @@ -36,15 +36,15 @@
> #define IMX_SC_R_DC_0_BLIT1 20
> #define IMX_SC_R_DC_0_BLIT2 21
> #define IMX_SC_R_DC_0_BLIT_OUT 22
> -#define IMX_SC_R_DC_0_CAPTURE0 23
> -#define IMX_SC_R_DC_0_CAPTURE1 24
> +#define IMX_SC_R_UNUSED19 23
> +#define IMX_SC_R_UNUSED5 24

If unused, don't define them.

2019-02-22 19:47:48

by Rob Herring (Arm)

Subject: Re: [PATCH V3 2/2] dt-bindings: imx: add new resources to scu resource table

On Wed, 20 Feb 2019 14:35:06 +0000, Anson Huang wrote:
> Add new resources as below according to latest system
> controller firmware for new features:
>
> IMX_SC_R_PERF
> IMX_SC_R_OCRAM
> IMX_SC_R_DMA_5_CH0
> IMX_SC_R_DMA_5_CH1
> IMX_SC_R_DMA_5_CH2
> IMX_SC_R_DMA_5_CH3
> IMX_SC_R_ATTESTATION
>
> Signed-off-by: Anson Huang <[email protected]>
> ---
> No changes since V2, just separate the patch to 2, 1 patch to remove resources and the other is to add new
> resources.
> ---
> include/dt-bindings/firmware/imx/rsrc.h | 11 ++++++++---
> 1 file changed, 8 insertions(+), 3 deletions(-)
>

Reviewed-by: Rob Herring <[email protected]>