2019-03-08 10:28:55

by Dmitrii Tcvetkov

[permalink] [raw]
Subject: NULL pointer dereference in nft_set_elem_destroy()

After upgrade to 5.0 on XPS 13 9360 I get NULL pointer dereference in
dmesg (attached). Distro is Arch Linux, kernel is built with custom
config (attached), but distro kernel[1] reproduces the issue on the
laptop as well.

Bisect led me to commit f6ac858589768 (netfilter: nf_tables: unbind set
in rule from commit path), bisect log attached. The commit doesn't
revert cleanly on top of v5.0, and conflicts aren't trivial for me to
resolve.

The issue reproduces only on the laptop, probably it has something to
do with it's ruleset, it's attached too.

[1] https://git.archlinux.org/svntogit/packages.git/plain/trunk/config?h=packages/linux


Attachments:
(No filename) (656.00 B)
dmesg.txt (73.98 kB)
kernel-config.txt (113.92 kB)
bisect-log.txt (2.74 kB)
nftables.conf (1.20 kB)
Download all attachments

2019-03-08 10:51:22

by Florian Westphal

[permalink] [raw]
Subject: Re: NULL pointer dereference in nft_set_elem_destroy()

Dmitrii Tcvetkov <[email protected]> wrote:
> After upgrade to 5.0 on XPS 13 9360 I get NULL pointer dereference in
> dmesg (attached). Distro is Arch Linux, kernel is built with custom
> config (attached), but distro kernel[1] reproduces the issue on the
> laptop as well.
>
> Bisect led me to commit f6ac858589768 (netfilter: nf_tables: unbind set
> in rule from commit path), bisect log attached. The commit doesn't
> revert cleanly on top of v5.0, and conflicts aren't trivial for me to
> resolve.

Please see
https://patchwork.ozlabs.org/patch/1053232/

this probably resolves this crash as well.

2019-03-08 21:36:30

by Dmitrii Tcvetkov

[permalink] [raw]
Subject: Re: NULL pointer dereference in nft_set_elem_destroy()

On Fri, 8 Mar 2019 11:50:39 +0100
Florian Westphal <[email protected]> wrote:

> Dmitrii Tcvetkov <[email protected]> wrote:
> > After upgrade to 5.0 on XPS 13 9360 I get NULL pointer dereference
> > in dmesg (attached). Distro is Arch Linux, kernel is built with
> > custom config (attached), but distro kernel[1] reproduces the issue
> > on the laptop as well.
> >
> > Bisect led me to commit f6ac858589768 (netfilter: nf_tables: unbind
> > set in rule from commit path), bisect log attached. The commit
> > doesn't revert cleanly on top of v5.0, and conflicts aren't trivial
> > for me to resolve.
>
> Please see
> https://patchwork.ozlabs.org/patch/1053232/
>
> this probably resolves this crash as well.

Thank you! With the patch nft loads ruleset fine.