2019-03-19 20:22:15

by Janusz Krzysztofik

Subject: [PATCH] ARM: OMAP1: ams-delta: Fix broken GPIO ID allocation

In order to request dynamic allocationn of GPIO IDs, a negative number
should be passed as a base GPIO ID via platform data. Unfortuntely,
commit 771e53c4d1a1 ("ARM: OMAP1: ams-delta: Drop board specific global
GPIO numbers") didn't follow that rule while switching to dynamically
allocated GPIO IDs for Amstrad Delta latches, making their IDs
overlapping with those already assigned to OMAP GPIO devices. Fix it.

Fixes: 771e53c4d1a1 ("ARM: OMAP1: ams-delta: Drop board specific global GPIO numbers")
Signed-off-by: Janusz Krzysztofik <[email protected]>
Cc: [email protected]
---
arch/arm/mach-omap1/board-ams-delta.c | 2 ++
1 file changed, 2 insertions(+)

diff --git a/arch/arm/mach-omap1/board-ams-delta.c b/arch/arm/mach-omap1/board-ams-delta.c
index be30c3c061b4..1b15d593837e 100644
--- a/arch/arm/mach-omap1/board-ams-delta.c
+++ b/arch/arm/mach-omap1/board-ams-delta.c
@@ -182,6 +182,7 @@ static struct resource latch1_resources[] = {

static struct bgpio_pdata latch1_pdata = {
.label = LATCH1_LABEL,
+ .base = -1,
.ngpio = LATCH1_NGPIO,
};

@@ -219,6 +220,7 @@ static struct resource latch2_resources[] = {

static struct bgpio_pdata latch2_pdata = {
.label = LATCH2_LABEL,
+ .base = -1,
.ngpio = LATCH2_NGPIO,
};

--
2.19.2

2019-03-20 01:03:44

by Aaro Koskinen

Subject: Re: [PATCH] ARM: OMAP1: ams-delta: Fix broken GPIO ID allocation

On Tue, Mar 19, 2019 at 09:19:52PM +0100, Janusz Krzysztofik wrote:
> In order to request dynamic allocationn of GPIO IDs, a negative number
> should be passed as a base GPIO ID via platform data. Unfortuntely,
> commit 771e53c4d1a1 ("ARM: OMAP1: ams-delta: Drop board specific global
> GPIO numbers") didn't follow that rule while switching to dynamically
> allocated GPIO IDs for Amstrad Delta latches, making their IDs
> overlapping with those already assigned to OMAP GPIO devices. Fix it.
>
> Fixes: 771e53c4d1a1 ("ARM: OMAP1: ams-delta: Drop board specific global GPIO numbers")
> Signed-off-by: Janusz Krzysztofik <[email protected]>
> Cc: [email protected]

Acked-by: Aaro Koskinen <[email protected]>

A.

2019-03-22 22:23:47

by Tony Lindgren

Subject: Re: [PATCH] ARM: OMAP1: ams-delta: Fix broken GPIO ID allocation

* Aaro Koskinen <[email protected]> [190320 01:02]:
> On Tue, Mar 19, 2019 at 09:19:52PM +0100, Janusz Krzysztofik wrote:
> > In order to request dynamic allocationn of GPIO IDs, a negative number
> > should be passed as a base GPIO ID via platform data. Unfortuntely,
> > commit 771e53c4d1a1 ("ARM: OMAP1: ams-delta: Drop board specific global
> > GPIO numbers") didn't follow that rule while switching to dynamically
> > allocated GPIO IDs for Amstrad Delta latches, making their IDs
> > overlapping with those already assigned to OMAP GPIO devices. Fix it.
> >
> > Fixes: 771e53c4d1a1 ("ARM: OMAP1: ams-delta: Drop board specific global GPIO numbers")
> > Signed-off-by: Janusz Krzysztofik <[email protected]>
> > Cc: [email protected]
>
> Acked-by: Aaro Koskinen <[email protected]>

Applying into omap-for-v5.1/fixes thanks.

Tony