2019-03-21 08:43:34

by Wei Yongjun

[permalink] [raw]

Subject: [PATCH -next] phy: tegra: xusb: fix typo in tegra186_usb2_pad_probe()

---

Fix a typo in tegra186_usb2_pad_probe(), 'usb2->clk' should be
'priv->usb2_trk_clk'.

Fixes: b8998e928030 ("phy: tegra: xusb: Add Tegra186 support")
Signed-off-by: Wei Yongjun <[email protected]>
---
drivers/phy/tegra/xusb-tegra186.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/phy/tegra/xusb-tegra186.c b/drivers/phy/tegra/xusb-tegra186.c
index 11ad6e4e4711..a627fe0b8e54 100644
--- a/drivers/phy/tegra/xusb-tegra186.c
+++ b/drivers/phy/tegra/xusb-tegra186.c
@@ -467,8 +467,8 @@ tegra186_usb2_pad_probe(struct tegra_xusb_padctl *padctl,
}

priv->usb2_trk_clk = devm_clk_get(&pad->dev, "trk");
- if (IS_ERR(usb2->clk)) {
- err = PTR_ERR(usb2->clk);
+ if (IS_ERR(priv->usb2_trk_clk)) {
+ err = PTR_ERR(priv->usb2_trk_clk);
dev_dbg(&pad->dev, "failed to get usb2 trk clock: %d\n", err);
goto unregister;
}

2019-03-21 15:06:58

by Thierry Reding

[permalink] [raw]

Subject: Re: [PATCH -next] phy: tegra: xusb: fix typo in tegra186_usb2_pad_probe()

---

On Thu, Mar 21, 2019 at 08:54:36AM +0000, Wei Yongjun wrote:
> Fix a typo in tegra186_usb2_pad_probe(), 'usb2->clk' should be
> 'priv->usb2_trk_clk'.
>
> Fixes: b8998e928030 ("phy: tegra: xusb: Add Tegra186 support")
> Signed-off-by: Wei Yongjun <[email protected]>
> ---
> drivers/phy/tegra/xusb-tegra186.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)

Good catch!

Acked-by: Thierry Reding <[email protected]>

>
> diff --git a/drivers/phy/tegra/xusb-tegra186.c b/drivers/phy/tegra/xusb-tegra186.c
> index 11ad6e4e4711..a627fe0b8e54 100644
> --- a/drivers/phy/tegra/xusb-tegra186.c
> +++ b/drivers/phy/tegra/xusb-tegra186.c
> @@ -467,8 +467,8 @@ tegra186_usb2_pad_probe(struct tegra_xusb_padctl *padctl,
> }
>
> priv->usb2_trk_clk = devm_clk_get(&pad->dev, "trk");
> - if (IS_ERR(usb2->clk)) {
> - err = PTR_ERR(usb2->clk);
> + if (IS_ERR(priv->usb2_trk_clk)) {
> + err = PTR_ERR(priv->usb2_trk_clk);
> dev_dbg(&pad->dev, "failed to get usb2 trk clock: %d\n", err);
> goto unregister;
> }
>
>
>

---

Attachments:

(No filename) (1.05 kB)
signature.asc (849.00 B)
Download all attachments