2019-04-06 09:39:16

by Hariprasad Kelam

Subject: [PATCH] KVM: x86: fix warning Using plain integer as NULL pointer

Changed passing argument as "0 to NULL" which resolves below sparse warning

arch/x86/kvm/x86.c:3096:61: warning: Using plain integer as NULL pointer

Signed-off-by: Hariprasad Kelam <[email protected]>
---
arch/x86/kvm/x86.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/x86/kvm/x86.c b/arch/x86/kvm/x86.c
index 099b851..39034ec 100644
--- a/arch/x86/kvm/x86.c
+++ b/arch/x86/kvm/x86.c
@@ -3093,7 +3093,7 @@ int kvm_vm_ioctl_check_extension(struct kvm *kvm, long ext)
break;
case KVM_CAP_NESTED_STATE:
r = kvm_x86_ops->get_nested_state ?
- kvm_x86_ops->get_nested_state(NULL, 0, 0) : 0;
+ kvm_x86_ops->get_nested_state(NULL, NULL, 0) : 0;
break;
default:
break;
--
2.7.4

2019-04-06 19:18:43

by Mukesh Ojha

Subject: Re: [PATCH] KVM: x86: fix warning Using plain integer as NULL pointer

On 4/6/2019 3:06 PM, Hariprasad Kelam wrote:
> Changed passing argument as "0 to NULL" which resolves below sparse warning
>
> arch/x86/kvm/x86.c:3096:61: warning: Using plain integer as NULL pointer
>
> Signed-off-by: Hariprasad Kelam <[email protected]>
Reviewed-by: Mukesh Ojha <[email protected]>

Cheers,
-Mukesh

> ---
> arch/x86/kvm/x86.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/x86/kvm/x86.c b/arch/x86/kvm/x86.c
> index 099b851..39034ec 100644
> --- a/arch/x86/kvm/x86.c
> +++ b/arch/x86/kvm/x86.c
> @@ -3093,7 +3093,7 @@ int kvm_vm_ioctl_check_extension(struct kvm *kvm, long ext)
> break;
> case KVM_CAP_NESTED_STATE:
> r = kvm_x86_ops->get_nested_state ?
> - kvm_x86_ops->get_nested_state(NULL, 0, 0) : 0;
> + kvm_x86_ops->get_nested_state(NULL, NULL, 0) : 0;
> break;
> default:
> break;

2019-04-08 16:56:45

by Sean Christopherson

Subject: Re: [PATCH] KVM: x86: fix warning Using plain integer as NULL pointer

Nit: For future reference, wrapping the warning text with quotes in the
shortlog would be helpful. I initially read it as "fix a warning by
using a plain integer as a NULL pointer". E.g.:

KVM: x86: fix warning "Using plain integer as NULL pointer"

On Sat, Apr 06, 2019 at 03:06:58PM +0530, Hariprasad Kelam wrote:
> Changed passing argument as "0 to NULL" which resolves below sparse warning

Nit: Use imperative mood to state what the patch does, as opposed to
talking about the change in the past tense. That allows using past
tense to describe things that actually did happen in the past. E.g.:

Pass "NULL" instead of "0" for a pointer argument when querying
KVM_CAP_NESTED_STATE to resolve the below sparse warning:

>
> arch/x86/kvm/x86.c:3096:61: warning: Using plain integer as NULL pointer
>
> Signed-off-by: Hariprasad Kelam <[email protected]>

Thanks for the fix!

Reviewed-by: Sean Christopherson <[email protected]>

> ---
> arch/x86/kvm/x86.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/x86/kvm/x86.c b/arch/x86/kvm/x86.c
> index 099b851..39034ec 100644
> --- a/arch/x86/kvm/x86.c
> +++ b/arch/x86/kvm/x86.c
> @@ -3093,7 +3093,7 @@ int kvm_vm_ioctl_check_extension(struct kvm *kvm, long ext)
> break;
> case KVM_CAP_NESTED_STATE:
> r = kvm_x86_ops->get_nested_state ?
> - kvm_x86_ops->get_nested_state(NULL, 0, 0) : 0;
> + kvm_x86_ops->get_nested_state(NULL, NULL, 0) : 0;
> break;
> default:
> break;
> --
> 2.7.4
>