2019-04-06 10:49:28

by Hariprasad Kelam

Subject: [PATCH] kernel: pid_namespace : fix warning Using plain integer as NULL pointer

changed passing function argument "0 to NULL" to fix below sparse
warning

kernel/pid_namespace.c:55:76: warning: Using plain integer as NULL
pointer

did changes to avoid checkpatch error "prefer a maximum 75 chars per
line"

Signed-off-by: Hariprasad Kelam <[email protected]>
---
kernel/pid_namespace.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/kernel/pid_namespace.c b/kernel/pid_namespace.c
index aa6e72f..6e4afdc 100644
--- a/kernel/pid_namespace.c
+++ b/kernel/pid_namespace.c
@@ -52,7 +52,8 @@ static struct kmem_cache *create_pid_cachep(unsigned int level)
mutex_lock(&pid_caches_mutex);
/* Name collision forces to do allocation under mutex. */
if (!*pkc)
- *pkc = kmem_cache_create(name, len, 0, SLAB_HWCACHE_ALIGN, 0);
+ *pkc =
+ kmem_cache_create(name, len, 0, SLAB_HWCACHE_ALIGN, NULL);
mutex_unlock(&pid_caches_mutex);
/* current can fail, but someone else can succeed. */
return READ_ONCE(*pkc);
--
2.7.4

2019-04-06 19:15:21

by Mukesh Ojha

Subject: Re: [PATCH] kernel: pid_namespace : fix warning Using plain integer as NULL pointer

On 4/6/2019 4:18 PM, Hariprasad Kelam wrote:
> changed passing function argument "0 to NULL" to fix below sparse
> warning
>
> kernel/pid_namespace.c:55:76: warning: Using plain integer as NULL
> pointer
>
> did changes to avoid checkpatch error "prefer a maximum 75 chars per
> line"
>
> Signed-off-by: Hariprasad Kelam <[email protected]>
Reviewed-by: Mukesh Ojha <[email protected]>

Cheers,
-Mukesh

> ---
> kernel/pid_namespace.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/kernel/pid_namespace.c b/kernel/pid_namespace.c
> index aa6e72f..6e4afdc 100644
> --- a/kernel/pid_namespace.c
> +++ b/kernel/pid_namespace.c
> @@ -52,7 +52,8 @@ static struct kmem_cache *create_pid_cachep(unsigned int level)
> mutex_lock(&pid_caches_mutex);
> /* Name collision forces to do allocation under mutex. */
> if (!*pkc)
> - *pkc = kmem_cache_create(name, len, 0, SLAB_HWCACHE_ALIGN, 0);
> + *pkc =
> + kmem_cache_create(name, len, 0, SLAB_HWCACHE_ALIGN, NULL);
> mutex_unlock(&pid_caches_mutex);
> /* current can fail, but someone else can succeed. */
> return READ_ONCE(*pkc);