2019-04-08 19:17:20

by Rikard Falkeborn

Subject: [PATCH] Coccinelle: kstrdup: Fix typo in warning messages

Replace 'kstrdep' with 'kstrdup' in warning messages.

Signed-off-by: Rikard Falkeborn <[email protected]>
---
scripts/coccinelle/api/kstrdup.cocci | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/scripts/coccinelle/api/kstrdup.cocci b/scripts/coccinelle/api/kstrdup.cocci
index 09cba54ed0cf..6d13d54a6ee6 100644
--- a/scripts/coccinelle/api/kstrdup.cocci
+++ b/scripts/coccinelle/api/kstrdup.cocci
@@ -76,7 +76,7 @@ p1 << r1.p1;
p2 << r1.p2;
@@

-cocci.print_main("WARNING opportunity for kstrdep",p1)
+cocci.print_main("WARNING opportunity for kstrdup",p1)
cocci.print_secs("strcpy",p2)

@script:python depends on org@
@@ -84,7 +84,7 @@ p1 << r2.p1;
p2 << r2.p2;
@@

-cocci.print_main("WARNING opportunity for kstrdep",p1)
+cocci.print_main("WARNING opportunity for kstrdup",p1)
cocci.print_secs("memcpy",p2)

@script:python depends on report@
@@ -92,7 +92,7 @@ p1 << r1.p1;
p2 << r1.p2;
@@

-msg = "WARNING opportunity for kstrdep (strcpy on line %s)" % (p2[0].line)
+msg = "WARNING opportunity for kstrdup (strcpy on line %s)" % (p2[0].line)
coccilib.report.print_report(p1[0], msg)

@script:python depends on report@
@@ -100,5 +100,5 @@ p1 << r2.p1;
p2 << r2.p2;
@@

-msg = "WARNING opportunity for kstrdep (memcpy on line %s)" % (p2[0].line)
+msg = "WARNING opportunity for kstrdup (memcpy on line %s)" % (p2[0].line)
coccilib.report.print_report(p1[0], msg)
--
2.21.0

2019-04-08 20:59:37

by Julia Lawall

Subject: Re: [PATCH] Coccinelle: kstrdup: Fix typo in warning messages

On Mon, 8 Apr 2019, Rikard Falkeborn wrote:

> Replace 'kstrdep' with 'kstrdup' in warning messages.
>
> Signed-off-by: Rikard Falkeborn <[email protected]>

Acked-by: [email protected]

Thanks for the patch!

julia

> ---
> scripts/coccinelle/api/kstrdup.cocci | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/scripts/coccinelle/api/kstrdup.cocci b/scripts/coccinelle/api/kstrdup.cocci
> index 09cba54ed0cf..6d13d54a6ee6 100644
> --- a/scripts/coccinelle/api/kstrdup.cocci
> +++ b/scripts/coccinelle/api/kstrdup.cocci
> @@ -76,7 +76,7 @@ p1 << r1.p1;
> p2 << r1.p2;
> @@
>
> -cocci.print_main("WARNING opportunity for kstrdep",p1)
> +cocci.print_main("WARNING opportunity for kstrdup",p1)
> cocci.print_secs("strcpy",p2)
>
> @script:python depends on org@
> @@ -84,7 +84,7 @@ p1 << r2.p1;
> p2 << r2.p2;
> @@
>
> -cocci.print_main("WARNING opportunity for kstrdep",p1)
> +cocci.print_main("WARNING opportunity for kstrdup",p1)
> cocci.print_secs("memcpy",p2)
>
> @script:python depends on report@
> @@ -92,7 +92,7 @@ p1 << r1.p1;
> p2 << r1.p2;
> @@
>
> -msg = "WARNING opportunity for kstrdep (strcpy on line %s)" % (p2[0].line)
> +msg = "WARNING opportunity for kstrdup (strcpy on line %s)" % (p2[0].line)
> coccilib.report.print_report(p1[0], msg)
>
> @script:python depends on report@
> @@ -100,5 +100,5 @@ p1 << r2.p1;
> p2 << r2.p2;
> @@
>
> -msg = "WARNING opportunity for kstrdep (memcpy on line %s)" % (p2[0].line)
> +msg = "WARNING opportunity for kstrdup (memcpy on line %s)" % (p2[0].line)
> coccilib.report.print_report(p1[0], msg)
> --
> 2.21.0
>
>

2019-07-06 12:22:31

by Masahiro Yamada

Subject: Re: [Cocci] [PATCH] Coccinelle: kstrdup: Fix typo in warning messages

On Tue, Apr 9, 2019 at 4:20 AM Julia Lawall <[email protected]> wrote:
>
>
>
> On Mon, 8 Apr 2019, Rikard Falkeborn wrote:
>
> > Replace 'kstrdep' with 'kstrdup' in warning messages.
> >
> > Signed-off-by: Rikard Falkeborn <[email protected]>
>
> Acked-by: [email protected]


Applied to linux-kbuild.



--
Best Regards
Masahiro Yamada