2019-04-26 18:32:41

by Bharath Vedartham

Subject: [PATCH] drivers/char/random.c: Make add_hwgenerator_randomness static

Make add_hwgenerator_randomness static as it is only declared on
drivers/char/random.c

Signed-off-by: Bharath Vedartham <[email protected]>
---
drivers/char/random.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/char/random.c b/drivers/char/random.c
index 38c6d1a..08fd00a 100644
--- a/drivers/char/random.c
+++ b/drivers/char/random.c
@@ -2342,7 +2342,7 @@ randomize_page(unsigned long start, unsigned long range)
* Those devices may produce endless random bits and will be throttled
* when our pool is full.
*/
-void add_hwgenerator_randomness(const char *buffer, size_t count,
+static void add_hwgenerator_randomness(const char *buffer, size_t count,
size_t entropy)
{
struct entropy_store *poolp = &input_pool;
--
2.7.4

2019-04-26 19:25:33

by Bharath Vedartham

Subject: Re: [PATCH] drivers/char/random.c: Make add_hwgenerator_randomness static

Hi,

Please ignore this patch. It breaks the build.

Thank you

On Fri, Apr 26, 2019 at 11:59 PM Bharath Vedartham <[email protected]> wrote:
>
> Make add_hwgenerator_randomness static as it is only declared on
> drivers/char/random.c
>
> Signed-off-by: Bharath Vedartham <[email protected]>
> ---
> drivers/char/random.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/char/random.c b/drivers/char/random.c
> index 38c6d1a..08fd00a 100644
> --- a/drivers/char/random.c
> +++ b/drivers/char/random.c
> @@ -2342,7 +2342,7 @@ randomize_page(unsigned long start, unsigned long range)
> * Those devices may produce endless random bits and will be throttled
> * when our pool is full.
> */
> -void add_hwgenerator_randomness(const char *buffer, size_t count,
> +static void add_hwgenerator_randomness(const char *buffer, size_t count,
> size_t entropy)
> {
> struct entropy_store *poolp = &input_pool;
> --
> 2.7.4
>

2019-04-26 20:08:34

by Theodore Ts'o

Subject: Re: [PATCH] drivers/char/random.c: Make add_hwgenerator_randomness static

On Sat, Apr 27, 2019 at 12:52:25AM +0530, Bharath Veda wrote:
> Hi,
>
> Please ignore this patch. It breaks the build.
>
> On Fri, Apr 26, 2019 at 11:59 PM Bharath Vedartham <[email protected]> wrote:
> >
> > Make add_hwgenerator_randomness static as it is only declared on
> > drivers/char/random.c

If one were to run the handy-dandy command "git grep
add_hwgenerator_randomness", one would find:

drivers/char/hw_random/core.c: add_hwgenerator_randomness((void *)rng_fillbuf, rc,
drivers/char/random.c:void add_hwgenerator_randomness(const char *buffer, size_t count,
drivers/char/random.c:EXPORT_SYMBOL_GPL(add_hwgenerator_randomness);
drivers/net/wireless/ath/ath9k/rng.c: add_hwgenerator_randomness((void *)rng_buf, bytes_read,
include/linux/hw_random.h:extern void add_hwgenerator_randomness(const char *buffer, size_t count, size_t entropy);

So the claim that it is only declared in drivers/char/random.c is not
true.

And of course, build-testing patches before sending them out for
review is a really good idea.

Cheers,

- Ted