2019-04-30 13:37:50

by Rasmus Villemoes

Subject: [PATCH 1/5] soc/fsl/qe: qe.c: drop useless static qualifier

The local variable snum_init has no reason to have static storage duration.

Signed-off-by: Rasmus Villemoes <[email protected]>
---
drivers/soc/fsl/qe/qe.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/soc/fsl/qe/qe.c b/drivers/soc/fsl/qe/qe.c
index 612d9c551be5..855373deb746 100644
--- a/drivers/soc/fsl/qe/qe.c
+++ b/drivers/soc/fsl/qe/qe.c
@@ -306,7 +306,7 @@ static void qe_snums_init(void)
0x28, 0x29, 0x38, 0x39, 0x48, 0x49, 0x58, 0x59,
0x68, 0x69, 0x78, 0x79, 0x80, 0x81,
};
- static const u8 *snum_init;
+ const u8 *snum_init;

qe_num_of_snum = qe_get_num_of_snums();

--
2.20.1

2019-04-30 17:05:22

by Christophe Leroy

Subject: Re: [PATCH 1/5] soc/fsl/qe: qe.c: drop useless static qualifier

Le 30/04/2019 à 15:36, Rasmus Villemoes a écrit :
> The local variable snum_init has no reason to have static storage duration.
>
> Signed-off-by: Rasmus Villemoes <[email protected]>

Reviewed-by: Christophe Leroy <[email protected]>

> ---
> drivers/soc/fsl/qe/qe.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/soc/fsl/qe/qe.c b/drivers/soc/fsl/qe/qe.c
> index 612d9c551be5..855373deb746 100644
> --- a/drivers/soc/fsl/qe/qe.c
> +++ b/drivers/soc/fsl/qe/qe.c
> @@ -306,7 +306,7 @@ static void qe_snums_init(void)
> 0x28, 0x29, 0x38, 0x39, 0x48, 0x49, 0x58, 0x59,
> 0x68, 0x69, 0x78, 0x79, 0x80, 0x81,
> };
> - static const u8 *snum_init;
> + const u8 *snum_init;
>
> qe_num_of_snum = qe_get_num_of_snums();
>
>