2019-05-12 11:36:24

by Hariprasad Kelam

Subject: [PATCH] drivers: staging :rtl8723bs :os_dep Remove Unneeded variable ret

fix below issue reported by coccicheck

drivers/staging/rtl8723bs/os_dep/ioctl_linux.c:2685:5-8: Unneeded
variable: "ret". Return "0" on line 3266

Signed-off-by: Hariprasad Kelam <[email protected]>
---
drivers/staging/rtl8723bs/os_dep/ioctl_linux.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/drivers/staging/rtl8723bs/os_dep/ioctl_linux.c b/drivers/staging/rtl8723bs/os_dep/ioctl_linux.c
index e3d3569..3f1ab6e 100644
--- a/drivers/staging/rtl8723bs/os_dep/ioctl_linux.c
+++ b/drivers/staging/rtl8723bs/os_dep/ioctl_linux.c
@@ -2682,7 +2682,6 @@ static int rtw_dbg_port(struct net_device *dev,
struct iw_request_info *info,
union iwreq_data *wrqu, char *extra)
{
- int ret = 0;
u8 major_cmd, minor_cmd;
u16 arg;
u32 extra_arg, *pdata, val32;
@@ -3263,7 +3262,7 @@ static int rtw_dbg_port(struct net_device *dev,
}


- return ret;
+ return 0;

}

--
2.7.4

2019-05-13 10:57:19

by Greg Kroah-Hartman

Subject: Re: [PATCH] drivers: staging :rtl8723bs :os_dep Remove Unneeded variable ret

On Sun, May 12, 2019 at 05:02:45PM +0530, Hariprasad Kelam wrote:
> fix below issue reported by coccicheck
>
> drivers/staging/rtl8723bs/os_dep/ioctl_linux.c:2685:5-8: Unneeded
> variable: "ret". Return "0" on line 3266
>
> Signed-off-by: Hariprasad Kelam <[email protected]>
> ---
> drivers/staging/rtl8723bs/os_dep/ioctl_linux.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)

For your subject line, put the ' ' character after the ':' character
always please.

Please fix up and resend.

thanks,

greg k-h

2019-05-13 11:26:33

by Dan Carpenter

Subject: Re: [PATCH] drivers: staging :rtl8723bs :os_dep Remove Unneeded variable ret

Please "drivers" out of the subject line. We know it's drivers, so that
doesn't add any information. The "staging: " bit tells you which git
tree this path is in, and the "rtl8723bs: " tells you which driver it
is.

regards,
dan carpenter