2019-05-15 13:17:06

by Naveen Kumar Parna

Subject: [PATCH] bsr: do not use assignment in if condition

From: Naveen Kumar Parna <[email protected]>

checkpatch.pl does not like assignment in if condition

Signed-off-by: Naveen Kumar Parna <[email protected]>
---
drivers/char/bsr.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/drivers/char/bsr.c b/drivers/char/bsr.c
index a6cef548e01e..2b00748b83d2 100644
--- a/drivers/char/bsr.c
+++ b/drivers/char/bsr.c
@@ -322,7 +322,8 @@ static int __init bsr_init(void)
goto out_err_2;
}

- if ((ret = bsr_create_devs(np)) < 0) {
+ ret = bsr_create_devs(np);
+ if (ret < 0) {
np = NULL;
goto out_err_3;
}
--
2.17.1

2019-05-15 13:34:17

by Greg Kroah-Hartman

Subject: Re: [PATCH] bsr: do not use assignment in if condition

On Wed, May 15, 2019 at 06:45:24PM +0530, [email protected] wrote:
> From: Naveen Kumar Parna <[email protected]>
>
> checkpatch.pl does not like assignment in if condition
>
> Signed-off-by: Naveen Kumar Parna <[email protected]>
> ---
> drivers/char/bsr.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/char/bsr.c b/drivers/char/bsr.c
> index a6cef548e01e..2b00748b83d2 100644
> --- a/drivers/char/bsr.c
> +++ b/drivers/char/bsr.c
> @@ -322,7 +322,8 @@ static int __init bsr_init(void)
> goto out_err_2;
> }
>
> - if ((ret = bsr_create_devs(np)) < 0) {
> + ret = bsr_create_devs(np);
> + if (ret < 0) {

Checkpatch also probably does not like that if statement :(

2019-05-15 14:17:09

by Greg Kroah-Hartman

Subject: Re: [PATCH] bsr: do not use assignment in if condition

On Wed, May 15, 2019 at 07:16:37PM +0530, Naveen Kumar Parna wrote:
> On Wed, 15 May 2019 at 19:02, Greg KH <[email protected]> wrote:
>
> > On Wed, May 15, 2019 at 06:45:24PM +0530, [email protected]
> > wrote:
> > > From: Naveen Kumar Parna <[email protected]>
> > >
> > > checkpatch.pl does not like assignment in if condition
> > >
> > > Signed-off-by: Naveen Kumar Parna <[email protected]>
> > > ---
> > > drivers/char/bsr.c | 3 ++-
> > > 1 file changed, 2 insertions(+), 1 deletion(-)
> > >
> > > diff --git a/drivers/char/bsr.c b/drivers/char/bsr.c
> > > index a6cef548e01e..2b00748b83d2 100644
> > > --- a/drivers/char/bsr.c
> > > +++ b/drivers/char/bsr.c
> > > @@ -322,7 +322,8 @@ static int __init bsr_init(void)
> > > goto out_err_2;
> > > }
> > >
> > > - if ((ret = bsr_create_devs(np)) < 0) {
> > > + ret = bsr_create_devs(np);
> > > + if (ret < 0) {
> >
> > Checkpatch also probably does not like that if statement :(
> >
> I ran checkpatch script and it did not show any warning or error.
>
> $ ./scripts/checkpatch.pl
> 0001-bsr-do-not-use-assignment-in-if-condition.patch
> total: 0 errors, 0 warnings, 9 lines checked
> 0001-bsr-do-not-use-assignment-in-if-condition.patch has no obvious style
> problems and is ready for submission.

Ok, then checkpatch missed it, but your eyes should have caught it.

When you are doing code style fixes outside of the drivers/staging/
area, you need to be very careful to be sure to get it right, as many
maintainers do not like the churn.

Please fix this up and resend.

thanks,

greg k-h