Fixes build errors:
ERROR: "mfd_remove_devices" [kpc2000.ko] undefined!
ERROR: "uio_unregister_device" [kpc2000.ko] undefined!
ERROR: "mfd_add_devices" [kpc2000.ko] undefined!
ERROR: "__uio_register_device" [kpc2000.ko] undefined!
Signed-off-by: Simon Sandström <[email protected]>
---
drivers/staging/kpc2000/Kconfig | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/staging/kpc2000/Kconfig b/drivers/staging/kpc2000/Kconfig
index c463d232f2b4..5188b56123ab 100644
--- a/drivers/staging/kpc2000/Kconfig
+++ b/drivers/staging/kpc2000/Kconfig
@@ -3,6 +3,8 @@
config KPC2000
bool "Daktronics KPC Device support"
depends on PCI
+ select MFD_CORE
+ select UIO
help
Select this if you wish to use the Daktronics KPC PCI devices
--
2.20.1
On Fri, May 24, 2019 at 10:30:58PM +0200, Simon Sandstr?m wrote:
> Fixes build errors:
>
> ERROR: "mfd_remove_devices" [kpc2000.ko] undefined!
> ERROR: "uio_unregister_device" [kpc2000.ko] undefined!
> ERROR: "mfd_add_devices" [kpc2000.ko] undefined!
> ERROR: "__uio_register_device" [kpc2000.ko] undefined!
>
> Signed-off-by: Simon Sandstr?m <[email protected]>
> ---
> drivers/staging/kpc2000/Kconfig | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/drivers/staging/kpc2000/Kconfig b/drivers/staging/kpc2000/Kconfig
> index c463d232f2b4..5188b56123ab 100644
> --- a/drivers/staging/kpc2000/Kconfig
> +++ b/drivers/staging/kpc2000/Kconfig
> @@ -3,6 +3,8 @@
> config KPC2000
> bool "Daktronics KPC Device support"
> depends on PCI
> + select MFD_CORE
> + select UIO
> help
> Select this if you wish to use the Daktronics KPC PCI devices
>
This is already in linux-next (in a different form), are you sure you
are working against the latest kernel tree?
thanks,
greg k-h
On Sat, May 25, 2019 at 07:00:17AM +0200, Greg KH wrote:
> On Fri, May 24, 2019 at 10:30:58PM +0200, Simon Sandström wrote:
> > Fixes build errors:
> >
> > ERROR: "mfd_remove_devices" [kpc2000.ko] undefined!
> > ERROR: "uio_unregister_device" [kpc2000.ko] undefined!
> > ERROR: "mfd_add_devices" [kpc2000.ko] undefined!
> > ERROR: "__uio_register_device" [kpc2000.ko] undefined!
> >
> > Signed-off-by: Simon Sandström <[email protected]>
> > ---
> > drivers/staging/kpc2000/Kconfig | 2 ++
> > 1 file changed, 2 insertions(+)
> >
> > diff --git a/drivers/staging/kpc2000/Kconfig b/drivers/staging/kpc2000/Kconfig
> > index c463d232f2b4..5188b56123ab 100644
> > --- a/drivers/staging/kpc2000/Kconfig
> > +++ b/drivers/staging/kpc2000/Kconfig
> > @@ -3,6 +3,8 @@
> > config KPC2000
> > bool "Daktronics KPC Device support"
> > depends on PCI
> > + select MFD_CORE
> > + select UIO
> > help
> > Select this if you wish to use the Daktronics KPC PCI devices
> >
>
> This is already in linux-next (in a different form), are you sure you
> are working against the latest kernel tree?
>
> thanks,
>
> greg k-h
It's based on your staging tree. I think that I have to go back and read
about next trees again, because I thought it took longer time for things
to get from staging-next to linux-next.
Anyway, neither the MFD_CORE nor the typo fix is in linux-next so I
guess that I could just rebase this on linux-next and re-send as v2.
I'm not sure if MFD_CORE should be "depends on" or "select" though...
- Simon
On Sat, May 25, 2019 at 10:39:18AM +0200, Simon Sandström wrote:
> On Sat, May 25, 2019 at 07:00:17AM +0200, Greg KH wrote:
> >
> > This is already in linux-next (in a different form), are you sure you
> > are working against the latest kernel tree?
> >
> > thanks,
> >
> > greg k-h
>
> It's based on your staging tree. I think that I have to go back and read
> about next trees again, because I thought it took longer time for things
> to get from staging-next to linux-next.
>
> Anyway, neither the MFD_CORE nor the typo fix is in linux-next so I
> guess that I could just rebase this on linux-next and re-send as v2.
> I'm not sure if MFD_CORE should be "depends on" or "select" though...
>
>
> - Simon
Oh, it must be "select MFD_CORE" because there is no prompt for
MFD_CORE? Should I just rebase it on linux-next and re-send as v2 then?
- Simon
On Sat, May 25, 2019 at 11:24:04AM +0200, Simon Sandstr?m wrote:
> On Sat, May 25, 2019 at 10:39:18AM +0200, Simon Sandstr?m wrote:
> > On Sat, May 25, 2019 at 07:00:17AM +0200, Greg KH wrote:
> > >
> > > This is already in linux-next (in a different form), are you sure you
> > > are working against the latest kernel tree?
> > >
> > > thanks,
> > >
> > > greg k-h
> >
> > It's based on your staging tree. I think that I have to go back and read
> > about next trees again, because I thought it took longer time for things
> > to get from staging-next to linux-next.
> >
> > Anyway, neither the MFD_CORE nor the typo fix is in linux-next so I
> > guess that I could just rebase this on linux-next and re-send as v2.
> > I'm not sure if MFD_CORE should be "depends on" or "select" though...
> >
> >
> > - Simon
>
> Oh, it must be "select MFD_CORE" because there is no prompt for
> MFD_CORE? Should I just rebase it on linux-next and re-send as v2 then?
Yes please.