2019-05-28 17:14:27

by Vladimir Davydov

[permalink] [raw]
Subject: Re: [PATCH v5 4/7] mm: unify SLAB and SLUB page accounting

On Tue, May 21, 2019 at 01:07:32PM -0700, Roman Gushchin wrote:
> Currently the page accounting code is duplicated in SLAB and SLUB
> internals. Let's move it into new (un)charge_slab_page helpers
> in the slab_common.c file. These helpers will be responsible
> for statistics (global and memcg-aware) and memcg charging.
> So they are replacing direct memcg_(un)charge_slab() calls.
>
> Signed-off-by: Roman Gushchin <[email protected]>
> Reviewed-by: Shakeel Butt <[email protected]>
> Acked-by: Christoph Lameter <[email protected]>

Makes sense even without the rest of the series,

Acked-by: Vladimir Davydov <[email protected]>